the code LGTM; however, could you expand the commit message (or add a comment in ...
10 years, 8 months ago
(2013-08-27 07:59:59 UTC)
#1
the code LGTM; however, could you expand the commit message (or add a comment in
the source) to explain why we want this? I think that this comment
http://code.google.com/p/lilypond/issues/detail?id=3359#c11 is a good material
and just needs a few rewords.
thanks,
Janek
On 2013/08/27 07:59:59, janek wrote: > could you expand the commit message (or add a ...
10 years, 8 months ago
(2013-08-27 17:44:52 UTC)
#2
On 2013/08/27 07:59:59, janek wrote:
> could you expand the commit message (or add a comment in
> the source) to explain why we want this?
Good point.
I put that comment where the test might make more sense, if we can figure out
how to put it there with the new organization after the unpure-pure-containers
patch.
On 2013/08/27 17:44:52, Keith wrote: > On 2013/08/27 07:59:59, janek wrote: > > could you ...
10 years, 8 months ago
(2013-08-27 22:36:01 UTC)
#3
On 2013/08/27 17:44:52, Keith wrote:
> On 2013/08/27 07:59:59, janek wrote:
> > could you expand the commit message (or add a comment in
> > the source) to explain why we want this?
>
> Good point.
> I put that comment where the test might make more sense, if we can figure out
> how to put it there with the new organization after the unpure-pure-containers
> patch.
I would nevertheless put some comment next to the code that's filtering the
problematic cases. But anyway LGTM.
thanks,
Janek
Issue 13013046: Trap pure-y-common spanning multiple staves; issue 3359
(Closed)
Created 10 years, 8 months ago by Keith
Modified 10 years, 8 months ago
Reviewers: janek
Base URL:
Comments: 0