Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 13013046: Trap pure-y-common spanning multiple staves; issue 3359 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by Keith
Modified:
10 years, 8 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Trap pure-y-common spanning multiple staves; issue 3359

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M lily/axis-group-interface.cc View 1 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 3
janek
the code LGTM; however, could you expand the commit message (or add a comment in ...
10 years, 8 months ago (2013-08-27 07:59:59 UTC) #1
Keith
On 2013/08/27 07:59:59, janek wrote: > could you expand the commit message (or add a ...
10 years, 8 months ago (2013-08-27 17:44:52 UTC) #2
janek
10 years, 8 months ago (2013-08-27 22:36:01 UTC) #3
On 2013/08/27 17:44:52, Keith wrote:
> On 2013/08/27 07:59:59, janek wrote:
> > could you expand the commit message (or add a comment in
> > the source) to explain why we want this?  
> 
> Good point. 
> I put that comment where the test might make more sense, if we can figure out
> how to put it there with the new organization after the unpure-pure-containers
> patch.

I would nevertheless put some comment next to the code that's filtering the
problematic cases.  But anyway LGTM.

thanks,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b