Issue 130080: [PATCH] Sanitize the JITResolver stub/callsite<->function maps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 130080: [PATCH] Sanitize the JITResolver stub/callsite<->function maps (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by Jeffrey Yasskin

Modified:
15 years, 1 month ago

Reviewers:

CC:
llvm-commits_cs.uiuc.edu

Visibility:
Public.

Description

The JITResolver maps Functions to their canonical stubs and all callsites for lazily-compiled functions to their target Functions. To make Function destruction work, I'm going to need to remove all callsites on destruction, so this patch also adds the reverse mapping for that. There was an incorrect assumption in here that the only stub for a function would be the one caused by needing to lazily compile it, while x86-64 far calls and dlsym-stubs could also cause such stubs, but I didn't look for a test case that the assumption broke. This also adds DenseMapInfo<AssertingVH> so I can use DenseMaps instead of std::maps.

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -43 lines)			Patch
	M	include/llvm/Support/ValueHandle.h	View		1 chunk	+25 lines, -0 lines	0 comments	Download
	M	lib/ExecutionEngine/JIT/JITEmitter.cpp	View		9 chunks	+99 lines, -43 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

15 years, 1 month ago (2009-10-14 23:28:38 UTC) #1

Patch at http://codereview.appspot.com/download/issue130080_1.diff

This passes check-lit.

Expand All Messages | Collapse All Messages