Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 13007044: changes: mention that decimal numbers can be written without # (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by janek
Modified:
10 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

changes: mention that decimal numbers can be written without # (change introduced by commit 680df85187d0f38)

Patch Set 1 #

Total comments: 1

Patch Set 2 : correct @lilypond to @example #

Total comments: 6

Patch Set 3 : Trevor's comments #

Patch Set 4 : trevor comment #

Total comments: 2

Patch Set 5 : Trevor & @code{\chordmode} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M Documentation/changes.tely View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 13
pkx166h
https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely#newcode76 Documentation/changes.tely:76: @end lilypond Did you mean to use an @example ...
10 years, 8 months ago (2013-08-19 20:09:39 UTC) #1
janek
correct @lilypond to @example
10 years, 8 months ago (2013-08-19 20:15:50 UTC) #2
janek
2013/8/19 <pkx166h@gmail.com>: > > https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely > File Documentation/changes.tely (right): > > https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely#newcode76 > Documentation/changes.tely:76: @end ...
10 years, 8 months ago (2013-08-19 20:17:27 UTC) #3
Trevor Daniels
Slightly better English, otherwise LGTM https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely#newcode65 Documentation/changes.tely:65: Decimal numbers can now ...
10 years, 8 months ago (2013-08-19 20:30:18 UTC) #4
janek
Trevor's comments
10 years, 8 months ago (2013-08-19 20:50:06 UTC) #5
janek
trevor comment
10 years, 8 months ago (2013-08-19 20:50:29 UTC) #6
janek
Thanks, Trevor! Corrected. https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely#newcode65 Documentation/changes.tely:65: Decimal numbers can now be written ...
10 years, 8 months ago (2013-08-19 20:51:24 UTC) #7
janek
Thanks, Trevor! Corrected.
10 years, 8 months ago (2013-08-19 20:51:32 UTC) #8
Trevor Daniels
Sorry to nitpick, otherwise LGTM No need to post a new patch set. https://codereview.appspot.com/13007044/diff/13001/Documentation/changes.tely File ...
10 years, 8 months ago (2013-08-19 22:37:58 UTC) #9
janek
Trevor & @code{\chordmode}
10 years, 8 months ago (2013-08-20 08:55:53 UTC) #10
janek
I found one more thing, so i've uploaded a new patch anyway. thanks! Jaennk https://codereview.appspot.com/13007044/diff/13001/Documentation/changes.tely ...
10 years, 8 months ago (2013-08-20 08:57:00 UTC) #11
Graham Percival
LGTM
10 years, 8 months ago (2013-08-21 14:28:53 UTC) #12
janek
10 years, 8 months ago (2013-08-24 10:49:19 UTC) #13
pushed as 59ee8eafd377bd11a4b0bf104db9aafc96b56d27
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b