Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2301)

Issue 12971044: Issue 3489: Let \cue... use quoted-context-type of CueVoice consistently (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3489: Let \cue... use quoted-context-type of CueVoice consistently Previously Voice was used and this relied on a a CueVoice purportedly being created by cue-substitute itself and providing a Voice alias. There is a regtest input/regression/quote-tuplet-end.ly which relied on an explicit Voice = "cue" serving as a substite catch for the cue notes, effectively turning \cueDuring into \quoteDuring. This kind of usage is rather bizarre, and since it diverts the \voiceOne/\voiceTwo settings for the cue voice into a CueVoice context anyway (which is otherwise empty), the cue voice is still missing proper directional information. This was not worth supporting. Regularizing the usage in this manner will reliably stop \quoteDuring from introducing surprise CueVoice contexts. Issue 3489: Let \quoteDuring descend to bottom context for its output Also regularizes interpretation of quoted-context-id. This patch by itself does not resolve the issue since a CueContext is created in any case, serving as Bottom and Voice context. A followup patch fixes that.

Patch Set 1 #

Patch Set 2 : Fix music display method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M lily/quote-iterator.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ly/music-functions-init.ly View 3 chunks +3 lines, -3 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 1 chunk +1 line, -1 line 0 comments Download
M scm/music-functions.scm View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2
dak
Fix music display method
10 years, 8 months ago (2013-08-21 07:29:12 UTC) #1
lemzwerg
10 years, 8 months ago (2013-08-21 07:33:18 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b