Issue 12945044: Remove 'thickness from LedgerLineSpanner interface.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12945044: Remove 'thickness from LedgerLineSpanner interface. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Mark Polesky

Modified:
10 years, 8 months ago

Reviewers:
janek, dak, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Remove 'thickness from LedgerLineSpanner interface.

Patch Set 2 : Fix cross-reference. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	lily/ledger-line-spanner.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Trevor Daniels

LGTM, apart from a query https://codereview.appspot.com/12945044/diff/1/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): https://codereview.appspot.com/12945044/diff/1/lily/ledger-line-spanner.cc#newcode331 lily/ledger-line-spanner.cc:331: " property of the ...

10 years, 8 months ago (2013-08-14 21:35:16 UTC) #1

Mark Polesky

On 2013/08/14 21:35:16, Trevor Daniels wrote: > Should this not be @ref{...}? No. @rinternals{...}. See ...

10 years, 8 months ago (2013-08-15 06:59:58 UTC) #2

dak

On 2013/08/15 06:59:58, Mark Polesky wrote: > On 2013/08/14 21:35:16, Trevor Daniels wrote: > > ...

10 years, 8 months ago (2013-08-15 07:24:48 UTC) #3

Mark Polesky

On 2013/08/15 07:24:48, dak wrote: > That documentation states as first entry: > > @ref{…} ...

10 years, 8 months ago (2013-08-15 09:43:33 UTC) #4

LGTM

Expand All Messages | Collapse All Messages