Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16657)

Issue 12921043: Tests for either cross-staff or supported by cross-staff stems to skip elements in pure side-positi…

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by MikeSol
Modified:
10 years, 8 months ago
Reviewers:
Keith, mike7
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Tests for either cross-staff or supported by cross-staff stems to skip elements in pure side-position-interface height calculations

Patch Set 1 #

Patch Set 2 : Never allows spanners to use cross staff grobs for side positioning #

Total comments: 1

Patch Set 3 : Prevents non-cross-staff elements from aligning to cross-staff elements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M lily/side-position-interface.cc View 1 2 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 4
MikeSol
Never allows spanners to use cross staff grobs for side positioning
10 years, 8 months ago (2013-08-15 06:46:16 UTC) #1
Keith
https://codereview.appspot.com/12921043/diff/3001/lily/side-position-interface.cc File lily/side-position-interface.cc (right): https://codereview.appspot.com/12921043/diff/3001/lily/side-position-interface.cc#newcode278 lily/side-position-interface.cc:278: // do not use cross_staff elements as supports of ...
10 years, 8 months ago (2013-08-15 07:29:43 UTC) #2
MikeSol
Prevents non-cross-staff elements from aligning to cross-staff elements
10 years, 8 months ago (2013-08-15 07:38:44 UTC) #3
mike7
10 years, 8 months ago (2013-08-15 07:39:27 UTC) #4
On 15 août 2013, at 10:29, k-ohara5a5a@oco.net wrote:

> 
>
https://codereview.appspot.com/12921043/diff/3001/lily/side-position-interfac...
> File lily/side-position-interface.cc (right):
> 
>
https://codereview.appspot.com/12921043/diff/3001/lily/side-position-interfac...
> lily/side-position-interface.cc:278: // do not use cross_staff elements
> as supports of spanners
> Well, I meant to suggest "do not use cross-staff elements as supports of
> objects that are not cross-staff" whether said elements are spanners or
> not.

Good call - patch up w/ this.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b