Issue 1292041: T487 - 'with' statement with mulitple managers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1292041: T487 - 'with' statement with mulitple managers

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Haoyu Bai

Modified:
13 years, 8 months ago

Reviewers:
craigcitro

CC:
craigcitro

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Added more tests #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -31 lines)			Patch
	M	Cython/Compiler/Parsing.py	View	1	1 chunk	+43 lines, -31 lines	0 comments	Download
	M	tests/run/withstat.pyx	View	1	1 chunk	+118 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

craigcitro

13 years, 8 months ago (2010-08-18 07:50:05 UTC) #1

LGTM

This looks great -- if I'm reading this correctly, you did this mostly by
refactoring the with parsing code, which is exactly the right way to implement
this (and also makes that code much more pleasant to read).

Expand All Messages | Collapse All Messages