Issue 129074: [PATCH] Make ExecutionEngine automatically remove global mappings on GlobalValue destruction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 129074: [PATCH] Make ExecutionEngine automatically remove global mappings on GlobalValue destruction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Jeffrey Yasskin

Modified:
14 years, 6 months ago

Reviewers:

CC:
llvm-commits_cs.uiuc.edu

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Comment why MapUpdatingCVH::deleted() doesn't need to setValPtr(0) #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -31 lines)			Patch
M	include/llvm/ExecutionEngine/ExecutionEngine.h	View		8 chunks	+43 lines, -20 lines	0 comments	Download
M	lib/ExecutionEngine/ExecutionEngine.cpp	View	1	10 chunks	+28 lines, -11 lines	0 comments	Download
M	unittests/ExecutionEngine/ExecutionEngineTest.cpp	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

14 years, 6 months ago (2009-10-13 00:43:30 UTC) #1

http://codereview.appspot.com/download/issue129074_5.diff

This doesn't make the ExecutionEngine do everything perfectly on GlobalValue
destruction (stubs still crash and machine code still leaks), but it's progress.

Expand All Messages | Collapse All Messages