Issue 129073: Fix #305: Allow alignment spanner to be broken for dynamics.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 129073: Fix #305: Allow alignment spanner to be broken for dynamics. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Neil Puttock

Modified:
13 years, 8 months ago

Reviewers:
hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix #305: Allow alignment spanner to be broken for dynamics. * introduce a new event class which will trigger the end of a DynamicLineSpanner prematurely, thus allowing dynamics to be positioned independently

Patch Set 1 #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -18 lines)			Patch
A	input/regression/dynamics-break-alignment.ly	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	lily/dynamic-align-engraver.cc	View	8 chunks	+29 lines, -14 lines	0 comments	Download
M	ly/spanners-init.ly	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	scm/define-event-classes.scm	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	scm/define-music-types.scm	View	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hanwenn

LGTM One doubt about the naming (that I proposed in the issue) - break_alignment could ...

14 years, 1 month ago (2010-03-04 15:02:37 UTC) #1

Neil Puttock

14 years, 1 month ago (2010-03-04 22:25:38 UTC) #2

On 2010/03/04 15:02:37, hanwenn wrote:
> LGTM
> 
> One doubt about the naming (that I proposed in the issue) - break_alignment
> could be misconstrued to be alignment-for-break.  Maybe alignment-breaker, or
> similar?

OK, alignment_breaker_ sounds fine.

BTW, I'm not ready to push this yet, since there are two details which I'd like
to sort out first:

1) Automatic breaking based on direction
(http://lists.gnu.org/archive/html/lilypond-devel/2009-10/msg00117.html)

2) Allow the Change_iterator to split alignments automatically.  This will
require some more extensive changes to the Dynamic_align_engraver, since the
break-dynamic-span-event will arrive later.

Cheers,
Neil

Expand All Messages | Collapse All Messages