code review 128510043: go.tools/cmd/html2article: handle heading elements

go.tools/cmd/html2article: handle heading elements

[francesc, 2014-08-20 18:23:03]

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[adg, 2014-08-20 23:45:48]

Just make it use a single * for all of them. Nobody will use the correct
headers in their google docs.


On 21 August 2014 04:23, <campoy@golang.org> wrote:

> Reviewers: adg,
>
> Message:
> Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/cmd/html2article: handle heading elements
>
> Please review this at https://codereview.appspot.com/128510043/
>
> Affected files (+3, -0 lines):
>   M cmd/html2article/conv.go
>
>
> Index: cmd/html2article/conv.go
> ===================================================================
> --- a/cmd/html2article/conv.go
> +++ b/cmd/html2article/conv.go
> @@ -232,6 +232,9 @@
>                         buf.WriteString(highlight(n, "`"))
>                 case atom.B:
>                         buf.WriteString(highlight(n, "*"))
> +               case atom.H1, atom.H2, atom.H3, atom.H4, atom.H5, atom.H6:
> +                       h := map[atom.Atom]int{atom.H1: 1, atom.H2: 2,
> atom.H3: 3, atom.H4: 4, atom.H5: 5, atom.H6: 6}[a]
> +                       fmt.Fprintf(&buf, "%s %s\n\n", strings.Repeat("*",
> h), childText(n))
>                 case atom.I:
>                         buf.WriteString(highlight(n, "_"))
>                 case atom.Img:
>
>
>

[francesc, 2014-08-21 02:11:15]

On 2014/08/20 23:45:48, adg wrote:
> Just make it use a single * for all of them. Nobody will use the correct
> headers in their google docs.
> 
> 
> On 21 August 2014 04:23, <mailto:campoy@golang.org> wrote:
> 
> > Reviewers: adg,
> >
> > Message:
> > Hello mailto:adg@golang.org (cc:
mailto:golang-codereviews@googlegroups.com),
> >
> > I'd like you to review this change to
> > https://code.google.com/p/go.tools
> >
> >
> > Description:
> > go.tools/cmd/html2article: handle heading elements
> >
> > Please review this at https://codereview.appspot.com/128510043/
> >
> > Affected files (+3, -0 lines):
> >   M cmd/html2article/conv.go
> >
> >
> > Index: cmd/html2article/conv.go
> > ===================================================================
> > --- a/cmd/html2article/conv.go
> > +++ b/cmd/html2article/conv.go
> > @@ -232,6 +232,9 @@
> >                         buf.WriteString(highlight(n, "`"))
> >                 case atom.B:
> >                         buf.WriteString(highlight(n, "*"))
> > +               case atom.H1, atom.H2, atom.H3, atom.H4, atom.H5, atom.H6:
> > +                       h := map[atom.Atom]int{atom.H1: 1, atom.H2: 2,
> > atom.H3: 3, atom.H4: 4, atom.H5: 5, atom.H6: 6}[a]
> > +                       fmt.Fprintf(&buf, "%s %s\n\n", strings.Repeat("*",
> > h), childText(n))
> >                 case atom.I:
> >                         buf.WriteString(highlight(n, "_"))
> >                 case atom.Img:
> >
> >
> >

Done, PTAL

[adg, 2014-08-21 02:49:18]

LGTM

[gobot, 2014-12-19 05:12:02]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/128510043 is best) in the description in your
new CL.

Thanks very much.