Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(215)

Issue 127480043: Issue 4070: Cyclic markup detection unable to deal with non-linear code execution (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4070: Cyclic markup detection unable to deal with non-linear code execution This uses dynamic winding to keep the stack depth counts accurate even in the presence of non-local exits like those used of map-markup-commands. It also changes the regtest markup-cyclic-reference.ly since it seems too much trouble to trap both cyclic references via a tortoise/hare algorithm as well as limiting the maximum markup stack depth.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M input/regression/markup-cyclic-reference.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/text-interface.cc View 3 chunks +15 lines, -20 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b