Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 12747043: Let Skyline's copy constructor use whole-sale copy construction of members (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
benko.pal
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let Skyline's copy constructor use whole-sale copy construction of members Originally connected with issue 3490, now separate.

Patch Set 1 #

Patch Set 2 : Use generated copy constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M lily/include/skyline.hh View 1 1 chunk +0 lines, -1 line 0 comments Download
M lily/skyline.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3
benko.pal
LGTM, but then why not let the compiler generate the copy constructor?
10 years, 8 months ago (2013-08-15 19:00:39 UTC) #1
dak
On 2013/08/15 19:00:39, benko.pal wrote: > LGTM, but then why not let the compiler generate ...
10 years, 8 months ago (2013-08-15 19:16:39 UTC) #2
dak
10 years, 8 months ago (2013-08-15 19:58:56 UTC) #3
Use generated copy constructor
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b