Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(211)

Issue 127000043: Doc: Appendix - Articulations and Ornamentation - part 3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by pkx166h
Modified:
7 years, 1 month ago
Reviewers:
Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Appendix - Articulations and Ornamentation - part 3 Issue 1189 Create Texifo @multitable entries for the List of Articulations appendix. As there are a lot of separate scripts being documented this Issue is going to be split into multiple, smaller, parts to aid in the review process. Part 2 was commit 4d6f2a27cc This is part 3 and while not strictly 'Articulations and ornamentations' covers the percussion scripts. I have also set the @code{} script examples into the same column as the @lilypond examples; saving a significant amount of wasted page space. I have removed unnecessary lilypond-book variables making the texinfo code less noisy.

Patch Set 1 #

Patch Set 2 : Corrected section error which broke make #

Total comments: 6

Patch Set 3 : With Trevor D's suggestions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -1 line) Patch
M Documentation/notation/notation-appendices.itely View 1 2 1 chunk +447 lines, -1 line 0 comments Download

Messages

Total messages: 6
pkx166h
Corrected section error which broke make
9 years, 8 months ago (2014-08-10 09:07:20 UTC) #1
Trevor Daniels
Suggested changes to index entries and spotted a couple of typos. Might it be better ...
9 years, 8 months ago (2014-08-10 09:51:38 UTC) #2
pkx166h
With Trevor D's suggestions.
9 years, 8 months ago (2014-08-11 18:19:42 UTC) #3
pkx166h
Thanks, Trevor. https://codereview.appspot.com/127000043/diff/20001/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): https://codereview.appspot.com/127000043/diff/20001/Documentation/notation/notation-appendices.itely#newcode1891 Documentation/notation/notation-appendices.itely:1891: @cindex tom tom, floor On 2014/08/10 09:51:38, ...
9 years, 8 months ago (2014-08-11 18:22:24 UTC) #4
Trevor Daniels
LGTM, James Thanks! Trevor
9 years, 8 months ago (2014-08-13 20:37:53 UTC) #5
pkx166h
7 years, 1 month ago (2017-03-19 13:18:38 UTC) #6
author    James Lowe <pkx166h@gmail.com>   
    Sun, 10 Aug 2014 08:34:20 +0000 (09:34 +0100)
committer    James Lowe <pkx166h@gmail.com>   
    Mon, 18 Aug 2014 15:20:41 +0000 (16:20 +0100)
commit    [r6beb9fee2733de250ecedd0573b4d0b577cb51a3]

This is Patch part 3.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b