Issue 12680046: code review 12680046: encoding/binary: speed up slices of basic type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12680046: code review 12680046: encoding/binary: speed up slices of basic type (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by r

Modified:
11 years, 4 months ago

Reviewers:
crawshaw1

CC:
golang-dev, crawshaw1

Visibility:
Public.

Description

encoding/binary: speed up writing slices of integers Simple approach. Still generates garbage, but not as much. benchmark old ns/op new ns/op delta BenchmarkWriteSlice1000Int32s 40260 18791 -53.33% benchmark old MB/s new MB/s speedup BenchmarkWriteSlice1000Int32s 99.35 212.87 2.14x Fixes issue 2634.

Patch Set 1 #

Patch Set 2 : diff -r 70d8d820bfe6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 70d8d820bfe6 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b20db4bc66df https://code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -0 lines)			Patch
	M	src/pkg/encoding/binary/binary.go	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download
	M	src/pkg/encoding/binary/binary_test.go	View	1 2	2 chunks	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2013-08-09 11:23:38 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 4 months ago (2013-08-09 11:25:40 UTC) #2

Hello golang-dev@googlegroups.com, crawshaw@google.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 4 months ago (2013-08-09 13:00:59 UTC) #5

11 years, 4 months ago (2013-08-09 13:15:22 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=0ad6ae7dfb68 ***

encoding/binary: speed up writing slices of integers

Simple approach. Still generates garbage, but not as much.

benchmark                        old ns/op    new ns/op    delta
BenchmarkWriteSlice1000Int32s        40260        18791  -53.33%

benchmark                         old MB/s     new MB/s  speedup
BenchmarkWriteSlice1000Int32s        99.35       212.87    2.14x

Fixes issue 2634.

R=golang-dev, crawshaw
CC=golang-dev
https://codereview.appspot.com/12680046

Expand All Messages | Collapse All Messages