Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(386)

Issue 12661: Implement non-standard tuplet numbers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by Reinhold
Modified:
14 years, 9 months ago
Reviewers:
hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement non-standard tuplet numbers -) Add function for different fraction than the actual tuplet fraction -) Add wrapper function that appends a note with given duration after the standard tuplet text (denominator or fraction) -) Add function to print tuplet text with both fraction values with a note duration attached -) Add snippet to be included in the Docs -) Add regtests for all these cases -) Remove definitions from musicxml2ly and make it use these new functions

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -36 lines) Patch
M Documentation/user/rhythms.itely View 1 chunk +3 lines, -0 lines 0 comments Download
A input/lsr/non-default-tuplet-numbers.ly View 1 chunk +35 lines, -0 lines 0 comments Download
M input/lsr/rhythms.snippet-list View 1 chunk +1 line, -0 lines 0 comments Download
A input/new/non-default-tuplet-numbers.ly View 1 chunk +32 lines, -0 lines 0 comments Download
M input/regression/musicxml/23c-Tuplet-Display-NonStandard.xml View 1 chunk +2 lines, -0 lines 0 comments Download
A input/regression/tuplet-text-different-numbers.ly View 1 chunk +15 lines, -0 lines 0 comments Download
A input/regression/tuplet-text-fraction-with-notes.ly View 1 chunk +12 lines, -0 lines 0 comments Download
A input/regression/tuplet-text-note-appended.ly View 1 chunk +13 lines, -0 lines 0 comments Download
M python/musicexp.py View 1 chunk +15 lines, -3 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +47 lines, -0 lines 4 comments Download
M scripts/musicxml2ly.py View 3 chunks +1 line, -33 lines 0 comments Download

Messages

Total messages: 2
hanwenn
lgtm http://codereview.appspot.com/12661/diff/1/11 File scm/output-lib.scm (right): http://codereview.appspot.com/12661/diff/1/11#newcode307 Line 307: (define-public ((tuplet-number::append-note-wrapper function note) grob) rename function ...
15 years, 2 months ago (2009-02-20 14:45:04 UTC) #1
Reinhold
15 years, 2 months ago (2009-02-20 19:42:27 UTC) #2
http://codereview.appspot.com/12661/diff/1/11
File scm/output-lib.scm (right):

http://codereview.appspot.com/12661/diff/1/11#newcode307
Line 307: (define-public ((tuplet-number::append-note-wrapper function note)
grob)
On 2009/02/20 14:45:04, hanwenn wrote:
> rename function to describe what it does.

This is a wrapper function, which simply appends a note to the output of the
wrapped function, so this name was the best I could come up to describe what it
does.

http://codereview.appspot.com/12661/diff/1/11#newcode322
Line 322: (define-public ((tuplet-number::non-default-tuplet-fraction-text
denominator numerator) grob)
I'm not sure if we can merge some functions. We need a function for numerator
only, one function for fraction, and two functions that print the note with the
numbers. The only two cases that can be merged is
tuplet-number::calc-denominator-text and
(tuplet-number::non-default-tuplet-denominator-text denominator), and similarly
for fractions. However, this requires a syntax change, since then one could no
longer set the property to tuplet-number::calc-denominator-text for the default
tuplet number, but has to use (tuplet-number::calc-denominator-text) instead. I
prefer not to do this.
Of course, I can still make the numerator and maybe also the denominator
optional in this case, but we can't really get rid of a function.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b