Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(821)

Issue 126350043: Add a convert-ly rule for xxx #'yyy #'zzz = -> xxx.yyy.zzz = (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add a convert-ly rule for xxx #'yyy #'zzz = -> xxx.yyy.zzz = Alist assignments can also use symbol list syntax as of issue 3748. So the examples for nested layout variable assignments should actually use those. Also contains commit: Run scripts/auxiliar/update-with-convert-ly.sh When pushed to staging, another commit reverting the convert-ly rule will be added since we don't want to apply somewhat generic patterns like those on unknown user-provided code when unchanged code remains valid. It turns out that this conversion applies to seriously erroneous documentation in Documentation/notation/spacing.itely and translations where normal assignments and overrides are getting confused. Fixing that would be a separate issue.

Patch Set 1 #

Patch Set 2 : conversion rule is only temporarily, so converted imported snippets need to be retained explicitly #

Patch Set 3 : Rebase on current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -137 lines) Patch
M Documentation/de/notation/spacing.itely View 4 chunks +9 lines, -9 lines 0 comments Download
M Documentation/es/extending/programming-interface.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/spacing.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/extending/programming-interface.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/extending/programming-interface.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/spacing.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/spacing.itely View 4 chunks +9 lines, -9 lines 0 comments Download
M Documentation/ly-examples/cary-layout.ily View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/spacing.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/displaying-grob-ancestry.ly View 1 2 chunks +9 lines, -8 lines 0 comments Download
A + Documentation/snippets/new/displaying-grob-ancestry.ly View 1 3 chunks +3 lines, -10 lines 0 comments Download
A + Documentation/snippets/new/vocal-ensemble-template.ly View 1 2 chunks +6 lines, -13 lines 0 comments Download
A + Documentation/snippets/new/vocal-ensemble-template-with-automatic-piano-reduction.ly View 1 2 chunks +6 lines, -13 lines 0 comments Download
M Documentation/snippets/vocal-ensemble-template.ly View 1 2 chunks +12 lines, -11 lines 0 comments Download
M Documentation/snippets/vocal-ensemble-template-with-automatic-piano-reduction.ly View 1 2 chunks +12 lines, -11 lines 0 comments Download
M input/regression/add-stem-support.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/baerenreiter-sarabande.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/dynamics-empty.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/ferneyhough-hairpins.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/morgenlied.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/mozart-hrn-3.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/note-names-context.ly View 2 chunks +2 lines, -3 lines 0 comments Download
M input/regression/page-breaking-min-distance.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/page-spacing.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/page-top-space.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/paper-nested-override.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/paper-nested-override2.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/skyline-point-extent.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/typography-demo.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M python/convertrules.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Trevor Daniels
LGTM Trevor
9 years, 8 months ago (2014-08-17 09:55:20 UTC) #1
dak
conversion rule is only temporarily, so converted imported snippets need to be retained explicitly
9 years, 8 months ago (2014-08-17 12:42:37 UTC) #2
dak
9 years, 8 months ago (2014-08-17 12:43:38 UTC) #3
Rebase on current master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b