Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(701)

Issue 126048: * killCues should not remove music quoted with \quoteDuring, only \cueDuring! (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by Reinhold
Modified:
14 years, 6 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

* killCues should not remove music quoted with \quoteDuring, only \cueDuring!

Patch Set 1 #

Patch Set 2 : Added regtest #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A input/regression/quote-kill-cues.ly View 1 chunk +16 lines, -0 lines 2 comments Download
M ly/music-functions-init.ly View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 1
Neil Puttock
14 years, 6 months ago (2009-09-29 16:31:20 UTC) #1
LGTM.

http://codereview.appspot.com/126048/diff/1001/4
File input/regression/quote-kill-cues.ly (right):

http://codereview.appspot.com/126048/diff/1001/4#newcode11
Line 11: q = \relative c' { d2 \quoteDuring #"M" { s1 } e2 \cueDuring #"M" #UP
{s1} f2 }
{ s1 }

http://codereview.appspot.com/126048/diff/1001/4#newcode14
Line 14: \displayMusic \q
for debug output?

http://codereview.appspot.com/126048/diff/1001/5
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/126048/diff/1001/5#newcode326
Line 326: (equal? (ly:music-property mus 'quoted-context-id) "cue"))
string=?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b