Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6538)

Issue 12562050: Increase tagline spacing (Issue 3214) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by PhilEHolmes
Modified:
10 years, 8 months ago
Reviewers:
janek, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Spacing from the tagline to any text is far too small to be pleasing. This patch increases it to be far more reasonable.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Alternative spacing mechanism #

Patch Set 3 : Regtests updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M input/regression/page-breaking-good-estimation.ly View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/page-turn-page-breaking.ly View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ly/titling-init.ly View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 7
PhilEHolmes
Please review
10 years, 8 months ago (2013-08-11 09:16:35 UTC) #1
dak
https://codereview.appspot.com/12562050/diff/1/ly/titling-init.ly File ly/titling-init.ly (right): https://codereview.appspot.com/12562050/diff/1/ly/titling-init.ly#newcode15 ly/titling-init.ly:15: \vspace #1.5 Inside of a line, this does not ...
10 years, 8 months ago (2013-08-11 09:58:10 UTC) #2
PhilEHolmes
Alternative spacing mechanism
10 years, 8 months ago (2013-08-11 10:30:51 UTC) #3
PhilEHolmes
Alterntive spacing mechanism - please review.
10 years, 8 months ago (2013-08-11 10:32:06 UTC) #4
PhilEHolmes
Regtests updated
10 years, 8 months ago (2013-08-12 10:58:28 UTC) #5
PhilEHolmes
Updating 2 regtests to prevent new overflow. Overflow would be expected, so allowing one regtest ...
10 years, 8 months ago (2013-08-12 11:00:46 UTC) #6
janek
10 years, 8 months ago (2013-08-14 11:53:51 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b