Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(365)

Issue 125620044: code review 125620044: cmd/yacc: remove Makefile and build expr using go generate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by r
Modified:
9 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/yacc: remove Makefile and build expr using go generate It now serves as an example for go generate as well as for yacc. NOTE: Depends on go generate, which is not yet checked in. This is a proof of concept of the approach. That is http://codereview.appspot.com/125580044.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 901a1adaf852b19c08d21b42f38ed145dcdb22f3 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
R src/cmd/yacc/Makefile View 1 chunk +0 lines, -12 lines 0 comments Download
A src/cmd/yacc/expr/README View 1 chunk +20 lines, -0 lines 0 comments Download
M src/cmd/yacc/expr/expr.y View 1 chunk +0 lines, -5 lines 0 comments Download
A src/cmd/yacc/expr/main.go View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2014-08-20 20:13:25 UTC) #1
rsc
LGTM https://codereview.appspot.com/125620044/diff/1/src/cmd/yacc/expr/expr.y File src/cmd/yacc/expr/expr.y (left): https://codereview.appspot.com/125620044/diff/1/src/cmd/yacc/expr/expr.y#oldcode14 src/cmd/yacc/expr/expr.y:14: // This tag will be copied to the ...
9 years, 8 months ago (2014-08-23 22:56:39 UTC) #2
r
9 years, 8 months ago (2014-08-24 18:34:49 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=68b84694821c ***

cmd/yacc: remove Makefile and build expr using go generate
It now serves as an example for go generate as well as for yacc.

NOTE: Depends on go generate, which is not yet checked in.
This is a proof of concept of the approach.
That is http://codereview.appspot.com/125580044.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/125620044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b