Issue 1255042: Fix ANGLE build with gcc 4.4 on Karmic.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1255042: Fix ANGLE build with gcc 4.4 on Karmic. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by thestig

Modified:
12 years, 10 months ago

Reviewers:
Alok Priyadarshi

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 4

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -1 line)			Patch
M	src/compiler/Intermediate.cpp	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	src/compiler/PoolAlloc.h	View	1 chunk	+1 line, -0 lines	2 comments	Download
M	src/compiler/PoolAlloc.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thestig

Fixes for errors that appeared on http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/3568/steps/compile/logs/stdio http://codereview.appspot.com/1255042/diff/1/2 File src/compiler/Intermediate.cpp (right): http://codereview.appspot.com/1255042/diff/1/2#newcode12 src/compiler/Intermediate.cpp:12: #include <limits.h> ...

14 years, 7 months ago (2010-05-19 01:20:33 UTC) #1

Fixes for errors that appeared on
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20Buil...

http://codereview.appspot.com/1255042/diff/1/2
File src/compiler/Intermediate.cpp (right):

http://codereview.appspot.com/1255042/diff/1/2#newcode12
src/compiler/Intermediate.cpp:12: #include <limits.h>
third_party/angle/src/compiler/Intermediate.cpp: In member function ‘virtual
TIntermTyped* TIntermConstantUnion::fold(TOperator, TIntermTyped*, TInfoSink&)’:
third_party/angle/src/compiler/Intermediate.cpp:1127: error: ‘INT_MAX’ was not
declared in this scope

http://codereview.appspot.com/1255042/diff/1/3
File src/compiler/PoolAlloc.cpp (right):

http://codereview.appspot.com/1255042/diff/1/3#newcode171
src/compiler/PoolAlloc.cpp:171: sprintf(assertMsg, "PoolAlloc: Damage %s %u byte
allocation at 0x%p\n",
third_party/angle/src/compiler/PoolAlloc.cpp: In member function ‘void
TAllocation::checkGuardBlock(unsigned char*, unsigned char, const char*) const’:
third_party/angle/src/compiler/PoolAlloc.cpp:172: warning: format ‘%lu’ expects
type ‘long unsigned int’, but argument 4 has type ‘unsigned int’

http://codereview.appspot.com/1255042/diff/1/4
File src/compiler/PoolAlloc.h (right):

http://codereview.appspot.com/1255042/diff/1/4#newcode35
src/compiler/PoolAlloc.h:35: #include <stdint.h>
third_party/angle/src/compiler/PoolAlloc.cpp: In member function ‘void*
TPoolAllocator::allocate(size_t)’:
third_party/angle/src/compiler/PoolAlloc.cpp:280: error: expected type-specifier
before ‘uintptr_t’
third_party/angle/src/compiler/PoolAlloc.cpp:280: error: expected ‘>’ before
‘uintptr_t’
third_party/angle/src/compiler/PoolAlloc.cpp:280: error: expected ‘(’ before
‘uintptr_t’
third_party/angle/src/compiler/PoolAlloc.cpp:280: error: ‘uintptr_t’ was not
declared in this scope
third_party/angle/src/compiler/PoolAlloc.cpp:280: error: expected ‘)’ before ‘;’
token

Alok Priyadarshi

14 years, 7 months ago (2010-05-19 04:46:02 UTC) #2

Hi Lei,
Thanks for doing this. I will make sure this still compiles on windows and
submit.

-Alok

http://codereview.appspot.com/1255042/diff/1/4
File src/compiler/PoolAlloc.h (right):

http://codereview.appspot.com/1255042/diff/1/4#newcode35
src/compiler/PoolAlloc.h:35: #include <stdint.h>
this will need to be guarded by ifndef win32

Expand All Messages | Collapse All Messages