Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 12476: Adds an experimental script to "fuse" gtest into 2 source files (a .h and a .cc)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by Zhanyong Wan
Modified:
9 years, 6 months ago
Reviewers:
Vlad
CC:
googletestframework_googlegroups.com
Base URL:
http://googletest.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Adds a Makefile for testing fuse_gtest.py. #

Total comments: 2

Patch Set 3 : addresses previous comments; adds the script to the release package. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -0 lines) Patch
Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download
scripts/fuse_gtest_files.py View 1 chunk +247 lines, -0 lines 0 comments Download
scripts/test/Makefile View 2 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Vlad
LGTM, with a couple of nits. http://codereview.appspot.com/12476/diff/3/202 File scripts/fuse_gtest.py (right): http://codereview.appspot.com/12476/diff/3/202#newcode32 Line 32: """fuse_gtest.py v0.1.0 ...
15 years, 3 months ago (2009-01-21 17:04:45 UTC) #1
Zhanyong Wan
15 years, 3 months ago (2009-01-21 20:06:14 UTC) #2
Thanks to Vlad for the review.  I renamed the script to fuse_gtest_files.py
based on his feedback.  How do other people like it?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b