LGTM, with a couple of nits. http://codereview.appspot.com/12476/diff/3/202 File scripts/fuse_gtest.py (right): http://codereview.appspot.com/12476/diff/3/202#newcode32 Line 32: """fuse_gtest.py v0.1.0 ...
15 years, 3 months ago
(2009-01-21 17:04:45 UTC)
#1
LGTM, with a couple of nits.
http://codereview.appspot.com/12476/diff/3/202
File scripts/fuse_gtest.py (right):
http://codereview.appspot.com/12476/diff/3/202#newcode32
Line 32: """fuse_gtest.py v0.1.0
Can you make the script name clearer by renaming it fuse_gtest_files? My first
reflex question when seeing the file name was 'What does it have to do with
FUSE?' Adding an a clearly recognizable object helps immediately recognize the
script purpose.
http://codereview.appspot.com/12476/diff/3/202#newcode52
Line 52: This tool is experimental. Please report any problems to
This tool assumes there is no conditional inclusion of gtest headers. Please
note it here.
Issue 12476: Adds an experimental script to "fuse" gtest into 2 source files (a .h and a .cc)
Created 15 years, 3 months ago by Zhanyong Wan
Modified 9 years, 6 months ago
Reviewers: Vlad
Base URL: http://googletest.googlecode.com/svn/trunk/
Comments: 2