Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 124057: Fix for Network equality

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by digitalxero
Modified:
9 years, 11 months ago
Reviewers:
Peter Moody
Base URL:
http://ipaddr-py.googlecode.com/svn/branches/2.0.x/
Visibility:
Public.

Description

Looking though the tests you have setup for ipaddr it is clear that you want the following to be True ip1 = ipaddr.IPv4Network('1.1.1.0/24') ip2 = ipaddr.IPv4Network('1.1.1.1/24') ip1 == ip2 based on this test self.assertEquals(ip1.compare_networks(ip2), 0) So I fixed the ><= operators to reflect this

Patch Set 1 #

Patch Set 2 : Updated patch to ensure the hashes are the same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
ipaddr.py View 1 4 chunks +7 lines, -7 lines 0 comments Download
ipaddr_test.py View 8 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3
digitalxero
14 years, 6 months ago (2009-09-28 00:12:13 UTC) #1
digitalxero
Updated patch to ensure the hashes are the same
14 years, 6 months ago (2009-09-28 16:15:33 UTC) #2
digitalxero
14 years, 6 months ago (2009-09-30 03:23:41 UTC) #3
Ok going though this patch a little more to make sure I didnt miss anything and
it conforms to the general consensus and I ran into a larger issue with the
library. testHash is defined twice and when I renamed the second one to
testHash1 so both were run and the first one defined fails because the ipv6
network and broadcast are equal.

So I reverted my patch so I was using the default ipaddr and the default tests
and only made the change so both Hash tests ran and the test still failed, I
dont know why or how to fix it
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b