LGTM On Aug 8, 2014 8:09 AM, <iant@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: ...
10 years, 8 months ago
(2014-08-08 16:18:06 UTC)
#2
LGTM
On Aug 8, 2014 8:09 AM, <iant@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: add another test case that gccgo crashed on
>
> Please review this at https://codereview.appspot.com/124020044/
>
> Affected files (+16, -0 lines):
> A test/fixedbugs/bug490.go
>
>
> Index: test/fixedbugs/bug490.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/fixedbugs/bug490.go
> @@ -0,0 +1,16 @@
> +// compile
> +
> +// Copyright 2014 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +// The gccgo compiler used to crash building a comparison between an
> +// interface and an empty struct literal.
> +
> +package p
> +
> +type S struct{}
> +
> +func F(v interface{}) bool {
> + return v == S{}
> +}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Issue 124020044: code review 124020044: test: add another test case that gccgo crashed on
(Closed)
Created 10 years, 8 months ago by iant
Modified 10 years, 8 months ago
Reviewers: gobot, minux
Base URL:
Comments: 0