Issue 1221041: Cleaned up Common.h. Removed unnecessary includes and typedefs. Removed tabs ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1221041: Cleaned up Common.h. Removed unnecessary includes and typedefs. Removed tabs ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Alok Priyadarshi

Modified:
14 years, 6 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Cleaned up Common.h. Removed unnecessary includes and typedefs. Removed tabs from PoolAlloc.h and replaced UINT_PTR with uintptr_t.

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+203 lines, -247 lines)			Patch
M	src/compiler/Common.h	View	3 chunks	+6 lines, -55 lines	0 comments	Download
M	src/compiler/OutputGLSL.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/OutputHLSL.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/PoolAlloc.cpp	View	7 chunks	+191 lines, -191 lines	0 comments	Download
M	src/compiler/Types.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

approved provided the VS build still works as normal