Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 1220044: Patching changes from thestig@chromium.org for fixing ANGLE build with gcc 4.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Alok Priyadarshi
Modified:
14 years, 4 months ago
Reviewers:
thestig, gmanchromium
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Patching changes from thestig@chromium.org for fixing ANGLE build with gcc 4.4 on Karmic. The original CL is here: http://codereview.appspot.com/1255042/show The only changes I have maded is moved the inclusion of stdint.h from PoolAlloc.h to PoolAlloc.cpp with #ifndef _MSC_VER guard.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/compiler/Intermediate.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/PoolAlloc.cpp View 2 chunks +5 lines, -2 lines 3 comments Download

Messages

Total messages: 4
Alok Priyadarshi
Hi Lei, I have made a minor change in your CL to make sure it ...
14 years, 4 months ago (2010-05-19 16:10:53 UTC) #1
thestig
http://codereview.appspot.com/1220044/diff/1/3 File src/compiler/PoolAlloc.cpp (left): http://codereview.appspot.com/1220044/diff/1/3#oldcode9 src/compiler/PoolAlloc.cpp:9: #include "compiler/Common.h" Are you sure it's safe to remove ...
14 years, 4 months ago (2010-05-19 18:41:21 UTC) #2
Alok Priyadarshi
http://codereview.appspot.com/1220044/diff/1/3 File src/compiler/PoolAlloc.cpp (left): http://codereview.appspot.com/1220044/diff/1/3#oldcode9 src/compiler/PoolAlloc.cpp:9: #include "compiler/Common.h" Do you see compile error? I can ...
14 years, 4 months ago (2010-05-19 19:49:14 UTC) #3
thestig
14 years, 4 months ago (2010-05-19 20:03:18 UTC) #4
LGTM with change below.

http://codereview.appspot.com/1220044/diff/1/3
File src/compiler/PoolAlloc.cpp (left):

http://codereview.appspot.com/1220044/diff/1/3#oldcode9
src/compiler/PoolAlloc.cpp:9: #include "compiler/Common.h"
Ya, adding stdio.h inside this #ifndef works too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b