Issue 1211045: Change public static variables in BasicImageRewriter as private

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1211045: Change public static variables in BasicImageRewriter as private (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by henry.saputra

Modified:
13 years ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Change the public modifier for static variables in BasicImageRewriter that exposes UriCommon.Param enums as private since they serve no purpose other than used in the unit test. Change CONTENT_TYPE_AND_EXTENSION_MISMATCH and CONTENT_TYPE_AND_MIME_MISMATCH as package private for easy access from the unit test. Updated the unit test to reflect this. Code review at http://codereview.appspot.com/1211045/show

Patch Set 1 #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -19 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BasicImageRewriter.java	View		2 chunks	+12 lines, -11 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/ImageRewriterTest.java	View		2 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

henry.saputra

13 years, 11 months ago (2010-05-21 16:16:11 UTC) #2

Code review for jira SHINDIG-1339. Forgot to include shindig.remailer when first
created (thanks Ziv).

Expand All Messages | Collapse All Messages