Issue 1209049: 9term: fix getpts on linux

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1209049: 9term: fix getpts on linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by ality

Modified:
13 years, 10 months ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Description

9term: fix getpts on linux Openpty uses grantpt internally and its behavior is unspecified when a handler is set to catch SIGCHLD. Fixes issue 37. http://code.swtch.com/plan9port/issues/37

Patch Set 1 #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/cmd/9term/Linux.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

14 years, 2 months ago (2010-06-28 21:32:59 UTC) #2

*** Submitted as 5727ca441f42 ***

9term: fix getpts on linux

Openpty uses grantpt internally and its behavior is
unspecified when a handler is set to catch SIGCHLD.

Fixes issue 37. http://code.swtch.com/plan9port/issues/37

R=rsc
CC=codebot
http://codereview.appspot.com/1209049

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages