https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf#newcode116 mf/feta-noteheads.mf:116: final_line_length := quanted_line_length * staff_space; This is rather hard ...
10 years, 8 months ago
(2013-07-29 17:08:00 UTC)
#1
----- Original Message ----- From: <dak@gnu.org> To: <PhilEHolmes@googlemail.com> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Monday, July 29, ...
10 years, 8 months ago
(2013-07-29 20:07:43 UTC)
#2
----- Original Message -----
From: <dak@gnu.org>
To: <PhilEHolmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Monday, July 29, 2013 6:08 PM
Subject: Corrects bounding box for longa (Issue 826) (issue 12032043)
>
> https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf
> File mf/feta-noteheads.mf (right):
>
>
https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf#newcode116
> mf/feta-noteheads.mf:116: final_line_length := quanted_line_length *
> staff_space;
> This is rather hard to figure out. Why don't you make
> define_pixels (final_line_length)
> and calculate final_line_length# as quanted_line_length * staff_space# ?
>
> The problem is that it is very hard to figure out the relation between
> boxtop# and final_line_length.
>
> https://codereview.appspot.com/12032043/
I'm not particularly confident with metafont code, and so generally try to
make the minimum change necessary to effect the desired result. That said, I
think final_line_length is a spurious variable, and so if you think the
relationship between it and the boxxxx variables is not clear, would suggest
deleting that variable.
--
Phil Holmes
Issue 12032043: Corrects bounding box for longa (Issue 826)
(Closed)
Created 10 years, 8 months ago by PhilEHolmes
Modified 10 years, 7 months ago
Reviewers: dak, email_philholmes.net
Base URL:
Comments: 1