Issue 12030043: Fixes bounding boxes for breves, improves longas (Issue 3480)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12030043: Fixes bounding boxes for breves, improves longas (Issue 3480) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by PhilEHolmes

Modified:
10 years, 8 months ago

Reviewers:
wl, dak, lemzwerg, mail

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fixes bounding boxes for breves, improves longas (Issue 3480)

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	mf/feta-noteheads.mf	View		4 chunks	+10 lines, -10 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dak

https://codereview.appspot.com/12030043/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): https://codereview.appspot.com/12030043/diff/1/mf/feta-noteheads.mf#newcode118 mf/feta-noteheads.mf:118: staff_space# * quanted_line_length); Does that mean that the bounding ...

10 years, 8 months ago (2013-07-30 12:41:40 UTC) #3

mail_philholmes.net

10 years, 8 months ago (2013-07-30 13:26:29 UTC) #4

----- Original Message ----- 
From: <dak@gnu.org>
To: <PhilEHolmes@googlemail.com>; <wl@gnu.org>; <lemzwerg@googlemail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Tuesday, July 30, 2013 1:41 PM
Subject: Re: Fixes bounding boxes for breves, improves longas (Issue 
3480)(issue 12030043)


>
> https://codereview.appspot.com/12030043/diff/1/mf/feta-noteheads.mf
> File mf/feta-noteheads.mf (right):
>
>
https://codereview.appspot.com/12030043/diff/1/mf/feta-noteheads.mf#newcode118
> mf/feta-noteheads.mf:118: staff_space# * quanted_line_length);
> Does that mean that the bounding box includes the whole stem of a longa
> in both up and down directions?  Or is this something else?  If it's
> something else, what is it that will reserve the space for the stem?
>
> https://codereview.appspot.com/12030043/


No - this patch increases the size of the bounding box to take account of 
the bars, but not the stem of the longa.  The other patch that's on Rietveld 
extends the bounding box asymmetrically to take account of the stem of the 
longa.

--
Phil Holmes

Expand All Messages | Collapse All Messages