Vertical spacing tutorial (Issue 2809)

First stab at a vertical spacing tutorial (Issue 2809).  Passes make doc.

[PhilEHolmes, 2013-07-27 14:02:31]

Please review

[Trevor Daniels, 2013-07-31 16:44:44]

LGTM.  You've picked up the style of the LM
nicely!  Thanks.

Trevor

https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
File Documentation/learning/tweaks.itely (right):

https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
Documentation/learning/tweaks.itely:2472: property.  Spacing them away from the
staff which they relate to
Sorry to be pedantic, but I'm of an age that still
prefers to see "to which" in print.

[email_philholmes.net, 2013-07-31 17:04:21]

----- Original Message ----- 
From: <tdanielsmusic@googlemail.com>
To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Wednesday, July 31, 2013 5:44 PM
Subject: Re: Vertical spacing tutorial (Issue 2809) (issue 11966043)


> LGTM.  You've picked up the style of the LM
> nicely!  Thanks.
>
> Trevor
>
>
>
>
https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
> File Documentation/learning/tweaks.itely (right):
>
>
https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
> Documentation/learning/tweaks.itely:2472: property.  Spacing them away
> from the staff which they relate to
> Sorry to be pedantic, but I'm of an age that still
> prefers to see "to which" in print.
>
> https://codereview.appspot.com/11966043/

I will change it before pushing, but "up with which I will not put" is 
relevant?

--
Phil Holmes 

[t.daniels_treda.co.uk, 2013-07-31 21:12:36]

Phil Holmes wrote Wednesday, July 31, 2013 6:04 PM

> From: <tdanielsmusic@googlemail.com>

>> Documentation/learning/tweaks.itely:2472: property.  Spacing them away
>> from the staff which they relate to
>> Sorry to be pedantic, but I'm of an age that still
>> prefers to see "to which" in print.
>>
>> https://codereview.appspot.com/11966043/
> 
> I will change it before pushing, but "up with which I will not put" is 
> relevant?

Not really.  Churchill probably never said this.  His command of English
was impeccable::

"The conditions of the Transvaal ordinance under which Chinese Labour is now
being carried on do not, in my opinion, constitute a state of slavery. A labour
contract into which men enter voluntarily for a limited and for a brief period,
under which they are paid wages which they consider adequate, under which they
are not bought or sold and from which they can obtain relief on payment of
seventeen pounds ten shillings, the cost of their passage, may not be a healthy
or proper contract, but it cannot in the opinion of His Majesty's Government be
classified as slavery in the extreme acceptance of the word without some risk of
terminological inexactitude." 

;-)

[Keith, 2013-08-02 07:06:12]

With one change, LGTM.

I did not think it wise to even try to explain LilyPond's interface for staff
spacing in the Learning Manual, but you seem to have tried and succeeded.

>
https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
> > Documentation/learning/tweaks.itely:2472: property.  Spacing them away
> > from the staff which they relate to
> > Sorry to be pedantic, but I'm of an age that still
> > prefers to see "to which" in print.
> >
> > https://codereview.appspot.com/11966043/
> 
> but "up with which I will not put" is relevant?
> 

You could argue that 'relate' is a verb used in its normal way and "to the
staves" is the implied prepositional phrase, so the "to which" belongs together.
 The French translation will probably use a single word 'dont' for "to which".

By contrast "put up with" is a phrasal verb whose meaning does not follow from
the usual meaning of "put" "up" and "with", so we keep it together -- and "put
up with" probably gets translated into a single word in French.

"How many children do you look after?"
"Under how many rocks did you look?"

https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
File Documentation/learning/tweaks.itely (right):

https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
Documentation/learning/tweaks.itely:2431: \new Score {
For some reason, people stopped using \new Score: issue 1033

https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
Documentation/learning/tweaks.itely:2565: @code{VerticalAxisGroup}, but this
time we're going to reduce both
This should be StaffGrouper again, as it was in the ChoirStaff.

Overriding the VerticalAxisGroup of each individual staff inside the PianoStaff,
as you have it now, would also close the space after the piano staff if there
were more staves below.

You might help people avoid issue 3482 if you encourage the pattern :
A) contexts that make groups of lines like GrandStaff, PianoStaff, etc., create
StaffGroup objects.
B) contexts that make single lines like Lyrics, Staff, etc., create
VerticalAxisGroup objects.

https://codereview.appspot.com/11966043/diff/1/Documentation/learning/tweaks....
Documentation/learning/tweaks.itely:2596: \override
VerticalAxisGroup.staff-staff-spacing = #'(
\override StaffGrouper.staff-staff-spacing.basic-distance = #0