code review 1193046: cgo: call fatal() with a descriptive error message if ...

cgo: call fatal() with a descriptive error message if the file does not
  consume any C symbols.

[dho, 2010-05-21 06:54:38]

reviewing myself.

http://codereview.appspot.com/1193046/diff/1/2
File src/cmd/cgo/main.go (right):

http://codereview.appspot.com/1193046/diff/1/2#newcode89
src/cmd/cgo/main.go:89: }
Should probably actually let the user know which file we're talking about here.

[dho, 2010-05-21 17:39:17]

Hello rsc, iant (cc: golang-dev@googlegroups.com, graeme.perrow@gmail.com),

I'd like you to review this change.

[rsc1, 2010-05-21 21:49:15]

LGTM

http://codereview.appspot.com/1193046/diff/4001/5001
File src/cmd/cgo/main.go (right):

http://codereview.appspot.com/1193046/diff/4001/5001#newcode88
src/cmd/cgo/main.go:88: fatal("No C symbols were used in cgo file: " + input)
fatal("no C symbols used in cgo file " + input)

(do not capitalize; no colon)

[dho, 2010-05-21 21:51:24]

Hello rsc, iant (cc: golang-dev@googlegroups.com, graeme.perrow@gmail.com),

Please take another look.

[rsc1, 2010-05-21 21:53:59]

LGTM

[rsc, 2010-05-22 00:31:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=f69ebed1f9ae ***

cgo: better error for no C symbols

R=rsc, iant
CC=golang-dev, graeme.perrow
http://codereview.appspot.com/1193046

Committer: Russ Cox <rsc@golang.org>

[rsc, 2010-05-24 16:58:10]

This broke the build; rolled back.

[dho, 2010-07-15 15:30:37]

*** Abandoned ***