Issue 1182042: Fixed compile error on MAC. Fixed TMap to use std::pair<const K, V> as pool_a...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1182042: Fixed compile error on MAC. Fixed TMap to use std::pair<const K, V> as pool_a... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Alok Priyadarshi

Modified:
14 years, 6 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fixed compile error on MAC. Fixed TMap to use std::pair<const K, V> as pool_allocator parameter. Replaced all instances of std::map with TMap. I wonder if this pool_allocator is worth all this complexity.

Patch Set 1 #

Total comments: 2

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -16 lines)			Patch
M	src/compiler/Common.h	View	3 chunks	+9 lines, -13 lines	2 comments	Download
M	src/compiler/SymbolTable.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/Types.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kbr1

LGTM http://codereview.appspot.com/1182042/diff/1/2 File src/compiler/Common.h (right): http://codereview.appspot.com/1182042/diff/1/2#newcode100 src/compiler/Common.h:100: class TMap : public std::map<K, D, CMP, pool_allocator<std::pair<const ...

14 years, 6 months ago (2010-05-12 18:00:16 UTC) #2

Alok Priyadarshi

14 years, 6 months ago (2010-05-12 18:35:23 UTC) #4

http://codereview.appspot.com/1182042/diff/1/2
File src/compiler/Common.h (right):

http://codereview.appspot.com/1182042/diff/1/2#newcode100
src/compiler/Common.h:100: class TMap : public std::map<K, D, CMP,
pool_allocator<std::pair<const K, D> > > {
No it was not necessary. I was just trying to clean the unnecessary cruft and
make it consistent with the declaration of TVector.

Expand All Messages | Collapse All Messages