Issue 11714: Bug 974: client side validation of CSS opacity style fails

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11714: Bug 974: client side validation of CSS opacity style fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by MikeSamuel

Modified:
16 years, 1 month ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

The <number:0,1> style was not getting properly translated to a regular expression.

Patch Set 1 #

Total comments: 3

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -3 lines)			Patch
	M	src/com/google/caja/lang/css/CssPropertyPatterns.java	View		9 chunks	+52 lines, -3 lines	3 comments	Download
	M	tests/com/google/caja/plugin/CssPropertyPatternsTest.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

metaweta

LGTM http://codereview.appspot.com/11714/diff/1/3 File src/com/google/caja/lang/css/CssPropertyPatterns.java (right): http://codereview.appspot.com/11714/diff/1/3#newcode330 Line 330: return patternSnippet.hashCode() ^ 0x4482de40; Where did this ...

16 years, 8 months ago (2009-01-12 23:02:03 UTC) #2

MikeSamuel

16 years, 8 months ago (2009-01-13 00:11:49 UTC) #3

http://codereview.appspot.com/11714/diff/1/3
File src/com/google/caja/lang/css/CssPropertyPatterns.java (right):

http://codereview.appspot.com/11714/diff/1/3#newcode330
Line 330: return patternSnippet.hashCode() ^ 0x4482de40;
On 2009/01/12 23:02:03, metaweta wrote:
> Where did this constant come from?

$ echo "$RANDOM$RANDOM" | perl -e 'printf("0x%x\n", <STDIN>)'

Expand All Messages | Collapse All Messages