Ns-3 Nix-vector Routing

src/common/packet.cc

 /* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */
 /*
  * Copyright (c) 2005,2006 INRIA
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation;
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 176 matching lines @@
   i.Write (buffer, size);
 }
 
 Packet::Packet (const Buffer &buffer,  const ByteTagList &byteTagList, 
                 const PacketTagList &packetTagList, const PacketMetadata &metadata)
   : m_buffer (buffer),
     m_byteTagList (byteTagList),
     m_packetTagList (packetTagList),
     m_metadata (metadata),
     m_refCount (1)
-{}
+{
+}
 
 Ptr<Packet>
 Packet::CreateFragment (uint32_t start, uint32_t length) const
 {
   NS_LOG_FUNCTION (this << start << length);
   Buffer buffer = m_buffer.CreateFragment (start, length);
   NS_ASSERT (m_buffer.GetSize () >= start + length);
   uint32_t end = m_buffer.GetSize () - (start + length);
   PacketMetadata metadata = m_metadata.CreateFragment (start, end);
   // again, call the constructor directly rather than
   // through Create because it is private.
   return Ptr<Packet> (new Packet (buffer, m_byteTagList, m_packetTagList, metadata), false);
 }
 
+void
+Packet::SetNixVector (Ptr<NixVector> nixVector)

[craigdo, 2009/09/11 22:38:17]

Again, I'm concerned about this kind of specific method in a generic packet. 
What happens if I want to add other things like this?  Packet explodes with
methods to SetNickVector or SetNackVector, etc?  Won't this lead to the dreaded
fragile base class?

[jpelkey, 2009/09/12 18:34:14]

On 2009/09/11 22:38:17, craigdo wrote:
> Again, I'm concerned about this kind of specific method in a generic packet. 
> What happens if I want to add other things like this?  Packet explodes with
> methods to SetNickVector or SetNackVector, etc?  Won't this lead to the
dreaded
> fragile base class?

These functions only exist because there wasn't a way to return the metadata
within Packet.  So in order to get and set the nix vector in packet-metadata, I
had to add these functions in packet in order to access the packet-metadata
functions, get/set nix-vector.  I was following the same structure as GetUid in
Packet.

+{
+  m_metadata.SetNixVector (nixVector);
+}
+
+Ptr<NixVector>
+Packet::GetNixVector (void) const
+{
+  return m_metadata.GetNixVector ();
+} 
+
 uint32_t 
 Packet::GetSize (void) const
 {
   return m_buffer.GetSize ();
 }
 
 void
 Packet::AddHeader (const Header &header)
 {
   uint32_t size = header.GetSerializedSize ();
@@ skipping 447 matching lines @@
           os << " ";
         }
     }
 }
 
 PacketTagIterator 
 Packet::GetPacketTagIterator (void) const
 {
   return PacketTagIterator (m_packetTagList.Head ());
 }
-
 
 std::ostream& operator<< (std::ostream& os, const Packet &packet)
 {
   packet.Print (os);
   return os;
 }
 
 
 } // namespace ns3
 
@@ skipping 411 matching lines @@
     tmp->PeekData ();
     CHECK (tmp, 1, E (20, 1, 1001));
   }
 
   return result;
 }
 
 } // namespace ns3
 
 #endif /* RUN_SELF_TESTS */