Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1543)

Issue 11682043: Allow decimal fractions with non-empty parts before and after '.' in music (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow decimal fractions with non-empty parts before and after '.' in music This permits writing things like mkMove = #(define-music-function (parser location x y) ( number? number? ) #{ \once \override TextScript #'extra-offset = #(cons x y) #}) { \mkMove 4.4 -3.3 c1^"XY" } Since integers are accepted in this kind of usage, not accepting floating point numbers appears inconsistent. While in INITIAL mode like inside of layout blocks, real numbers can be written like 4. or -.3 for historic reasons, permitting this inside of music could easily lead to confusion with durations or articulations, so those spellings remain invalid in music modes.

Patch Set 1 #

Patch Set 2 : Can't allow in chordmode because of c:13.11^3.7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
lily/lexer.ll View 1 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 3
dak
Can't allow in chordmode because of c:13.11^3.7
10 years, 9 months ago (2013-07-22 17:58:58 UTC) #1
janek
WOW!! I've just found this patch and this is awesome!! In my eyes, this single ...
10 years, 8 months ago (2013-08-18 14:00:28 UTC) #2
janek
10 years, 8 months ago (2013-08-19 11:07:19 UTC) #3
2013/8/18  <janek.lilypond@gmail.com>:
> WOW!! I've just found this patch and this is awesome!!
> In my eyes, this single patch made LilyPond 2 times more user-friendly.
>
> I think that this is totally worth of an entry in "changes" - i would be
> soooooo sorry if i hadn't found this change by accident today.  Would
> you like to write one or shall i do this?

http://code.google.com/p/lilypond/issues/detail?id=3506
and also
http://lilypondblog.org/2013/08/lilypond-became-more-user-friendly-overnight/
:)

best,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b