Issue 116540043: Fix lilypond-book include paths (issue 4046)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116540043: Fix lilypond-book include paths (issue 4046)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by Julien Rioux

Modified:
9 years, 8 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fix lilypond-book include paths (issue 4046) Add reg test

Patch Set 1 #

Patch Set 2 : Fix references when using --use-source-file-names, use lybook-testdb when running tests, add missin… #

Patch Set 3 : Fix for Windows: Always use forward slashes since this is what lilypond expects #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -18 lines)			Patch
M	input/regression/lilypond-book/GNUmakefile	View	1	1 chunk	+2 lines, -1 line	1 comment	Download
M	input/regression/lilypond-book/include.ly	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	input/regression/lilypond-book/melody.ly	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	input/regression/lilypond-book/tex-include-file.lytex	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	input/regression/lilypond-book/tex-include-options.lytex	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	input/regression/lilypond-book/texinfo-include-file.tely	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	python/book_snippets.py	View	1	1 chunk	+14 lines, -4 lines	0 comments	Download
M	scm/lily.scm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/lilypond-book.py	View	1 2	5 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Julien Rioux

Fix references when using --use-source-file-names, use lybook-testdb when running tests, add missing newline

9 years, 9 months ago (2014-08-08 21:30:12 UTC) #1

Julien Rioux

Fix for Windows: Always use forward slashes since this is what lilypond expects

9 years, 9 months ago (2014-08-09 21:08:11 UTC) #2

dak

9 years, 8 months ago (2014-08-21 21:11:25 UTC) #3

https://codereview.appspot.com/116540043/diff/40001/input/regression/lilypond...
File input/regression/lilypond-book/GNUmakefile (right):

https://codereview.appspot.com/116540043/diff/40001/input/regression/lilypond...
input/regression/lilypond-book/GNUmakefile:22: make
LYS_OUTPUT_DIR=$(top-build-dir)/out/lybook-testdb $(OUT_FILES)
Recursive invocations of make are comparatively ugly things.  In order to get
dependencies and flags right, they need to be called as $(MAKE) (please see the
node "MAKE Variable" in the documentation for GNU make) rather than just "make".

Expand All Messages | Collapse All Messages