Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 1163041: The script for flex and bison was not being generated properly on linux. Extr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by Alok Priyadarshi
Modified:
16 years, 1 month ago
Reviewers:
Mark Mentovai, kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The script for flex and bison was not being generated properly on linux. Extra quotes were being generated in the command-line around output-file path. This change gets around the problem by expanding string variables instead of list. This has another nice side effect that output file path need not be repeated twice.

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/build_angle.gyp View 1 4 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5
Alok Priyadarshi
16 years, 1 month ago (2010-05-07 19:55:02 UTC) #1
Mark Mentovai
lg otherwise http://codereview.appspot.com/1163041/diff/1/2 File src/build_angle.gyp (right): http://codereview.appspot.com/1163041/diff/1/2#newcode15 src/build_angle.gyp:15: 'glslang_cpp': '<(INTERMEDIATE_DIR)/glslang.cpp', Variables that refer to pathnames ...
16 years, 1 month ago (2010-05-07 19:58:27 UTC) #2
Alok Priyadarshi
Added _file suffix
16 years, 1 month ago (2010-05-07 20:06:08 UTC) #3
Mark Mentovai
LGTM
16 years, 1 month ago (2010-05-07 20:38:47 UTC) #4
kbr1
16 years, 1 month ago (2010-05-08 06:05:59 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b