[FreeType] Always use MONO hinting when hinting in monochrome.

[FreeType] Always use MONO hinting when hinting in monochrome.

This matches the behaviour of Cairo. It appears to be an undocumented
trick of font rendering on Linux that, in monochrome, all the hinting
modes expect no-hinting are mapped to FreeType's MONO hinting.

http://code.google.com/p/chromium/issues/detail?id=43252

[evan, 2010-05-07 23:50:39]

Do we have any way to test this?

Will this break Android?

LGTM in any case

[evan, 2010-05-09 15:59:20]

http://codereview.appspot.com/1162041/diff/1/2
File src/ports/SkFontHost_FreeType.cpp (right):

http://codereview.appspot.com/1162041/diff/1/2#newcode363
src/ports/SkFontHost_FreeType.cpp:363: loadFlags = FT_LOAD_NO_HINTING;
BTW, from that cairo snippet you pasted I noticed they're also using
FT_LOAD_MONOCHROME.  I wonder if that matters.  (They also use two variables,
load_target and load_flags, and I expect they're eventually OR'd together, so
perhaps more of these flags apply than you'd expect on first read.)

[agl, 2010-05-10 14:18:10]

On Fri, May 7, 2010 at 7:50 PM,  <evan@chromium.org> wrote:
> Do we have any way to test this?

The day of work required to write a test for this isn't worthwhile,
although it makes me sad that writing tests is so hard these days.

> Will this break Android?

I believe not. I don't think they use mono text and, even if they do
in some cases, I'm sure they hint it fully.


AGL