Issue 116060: Add request state on status bar

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116060: Add request state on status bar (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by yangoon1

Modified:
14 years, 7 months ago

Reviewers:
timitos, udono, ced1

Visibility:
Public.

Description

Patch uploaded, thx for comments!

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add gettetx on message #

Total comments: 1

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tryton/gui/main.py	View	1	3 chunks	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ced1

http://codereview.appspot.com/116060/diff/1/2 File tryton/gui/main.py (right): http://codereview.appspot.com/116060/diff/1/2#newcode1070 Line 1070: message = 'Waiting requests: %s received - %s ...

14 years, 7 months ago (2009-09-09 12:51:54 UTC) #2

yangoon1

http://codereview.appspot.com/116060/diff/1/2 File tryton/gui/main.py (right): http://codereview.appspot.com/116060/diff/1/2#newcode1070 Line 1070: message = 'Waiting requests: %s received - %s ...

14 years, 7 months ago (2009-09-09 13:03:00 UTC) #3

udono

only a minor wording issue. But anyway it looks ok for me. http://codereview.appspot.com/116060/diff/1003/1004 File tryton/gui/main.py ...

14 years, 7 months ago (2009-09-09 13:57:19 UTC) #5

yangoon1

14 years, 7 months ago (2009-09-09 14:50:21 UTC) #6

On 2009/09/09 13:57:19, udo.spallek wrote:
> only a minor wording issue. But anyway it looks ok for me.
> 
> http://codereview.appspot.com/116060/diff/1003/1004
> File tryton/gui/main.py (right):
> 
> http://codereview.appspot.com/116060/diff/1003/1004#newcode1070
> Line 1070: message = _('Waiting requests: %s received - %s sent') % (len(ids),
> Iam not sure if 'Waiting requests' is a good term. What about 'open' or
'unread'
> like used in tracker or email?
> Or just simply 'Requests:'?

This is exactly the state of those requests. And I find the state is correctly
named as 'Requests *waiting* for handling'

Expand All Messages | Collapse All Messages