http://codereview.appspot.com/116060/diff/1/2 File tryton/gui/main.py (right): http://codereview.appspot.com/116060/diff/1/2#newcode1070 Line 1070: message = 'Waiting requests: %s received - %s ...
15 years, 6 months ago
(2009-09-09 13:03:00 UTC)
#3
http://codereview.appspot.com/116060/diff/1/2
File tryton/gui/main.py (right):
http://codereview.appspot.com/116060/diff/1/2#newcode1070
Line 1070: message = 'Waiting requests: %s received - %s sent' % (len(ids),
On 2009/09/09 12:51:55, ced wrote:
> You should use gettext for the string and perhaps the plurial forms.
Thx. I explicitly used this abstract form to avoid clushes with plurals. So I
don't think it is necessary to take this into account.
On 2009/09/09 13:57:19, udo.spallek wrote: > only a minor wording issue. But anyway it looks ...
15 years, 6 months ago
(2009-09-09 14:50:21 UTC)
#6
On 2009/09/09 13:57:19, udo.spallek wrote:
> only a minor wording issue. But anyway it looks ok for me.
>
> http://codereview.appspot.com/116060/diff/1003/1004
> File tryton/gui/main.py (right):
>
> http://codereview.appspot.com/116060/diff/1003/1004#newcode1070
> Line 1070: message = _('Waiting requests: %s received - %s sent') % (len(ids),
> Iam not sure if 'Waiting requests' is a good term. What about 'open' or
'unread'
> like used in tracker or email?
> Or just simply 'Requests:'?
This is exactly the state of those requests. And I find the state is correctly
named as 'Requests *waiting* for handling'
Issue 116060: Add request state on status bar
(Closed)
Created 15 years, 6 months ago by yangoon1
Modified 15 years, 6 months ago
Reviewers: ced1, udono, timitos
Base URL:
Comments: 3