Issue 115320043: Issue 4033: All subsequent clef transpositions are marked as optional

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115320043: Issue 4033: All subsequent clef transpositions are marked as optional (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by dak

Modified:
9 years, 6 months ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 4033: All subsequent clef transpositions are marked as optional This removes a bug cover-up in scm/parser-clef.scm, implements the necessary functionality in display-lily-music and adds some regtests for that functionality.

Patch Set 1 #

Patch Set 2 : Clean up make-clef-set code. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -52 lines)			Patch
M	input/regression/display-lily-tests.ly	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scm/define-music-display-methods.scm	View		1 chunk	+16 lines, -11 lines	0 comments	Download
M	scm/parser-clef.scm	View	1	1 chunk	+19 lines, -41 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

janek

9 years, 9 months ago (2014-07-31 20:21:14 UTC) #2

I don't have enough time to really review the code, but i'm glad to see this
issue being addressed - thanks!
Janek

Expand All Messages | Collapse All Messages