Add "Forms/Statusbar" option

Patch sent.

[ced1, 2009-09-10 10:09:03]

http://codereview.appspot.com/115085/diff/1/3
File tryton/gui/main.py (right):

http://codereview.appspot.com/115085/diff/1/3#newcode980
Line 980: try:
Why a try except ?

[udono, 2009-09-10 10:14:03]

Looks good for me.

[yangoon1, 2009-09-10 11:24:29]

On 2009/09/10 10:09:03, ced wrote:
> http://codereview.appspot.com/115085/diff/1/3
> File tryton/gui/main.py (right):
> 
> http://codereview.appspot.com/115085/diff/1/3#newcode980
> Line 980: try:
> Why a try except ?

Because without I get on first login

Traceback (most recent call last):
  File "/usr/src/tmp/tryton/tryton/gui/main.py", line 665, in <lambda>
    lambda menuitem: self.sig_statusbar_change(menuitem.get_active()))
  File "/usr/src/tmp/tryton/tryton/gui/main.py", line 976, in
sig_statusbar_change
    return self.sig_statusbar_show()
  File "/usr/src/tmp/tryton/tryton/gui/main.py", line 983, in sig_statusbar_show
    self.status_hbox.show()
AttributeError: 'Main' object has no attribute 'status_hbox'

and AFAIS it would afford a major rewrite to get this done without exception.

[ced1, 2009-09-10 11:56:46]

On 2009/09/10 11:24:29, yangoon wrote:
> On 2009/09/10 10:09:03, ced wrote:
> > http://codereview.appspot.com/115085/diff/1/3
> > File tryton/gui/main.py (right):
> > 
> > http://codereview.appspot.com/115085/diff/1/3#newcode980
> > Line 980: try:
> > Why a try except ?
> 
> Because without I get on first login
> 
> Traceback (most recent call last):
>   File "/usr/src/tmp/tryton/tryton/gui/main.py", line 665, in <lambda>
>     lambda menuitem: self.sig_statusbar_change(menuitem.get_active()))
>   File "/usr/src/tmp/tryton/tryton/gui/main.py", line 976, in
> sig_statusbar_change
>     return self.sig_statusbar_show()
>   File "/usr/src/tmp/tryton/tryton/gui/main.py", line 983, in
sig_statusbar_show
>     self.status_hbox.show()
> AttributeError: 'Main' object has no attribute 'status_hbox'
> 
> and AFAIS it would afford a major rewrite to get this done without exception.

I don't understand because status_hbox is set before in the call set_statusbar
at line 140
And any way, a try except for that is bad. You should at least test is
status_hbox is not None

[yangoon1, 2009-09-10 14:46:55]

On 2009/09/10 11:56:46, ced wrote:
> On 2009/09/10 11:24:29, yangoon wrote:
> > On 2009/09/10 10:09:03, ced wrote:
> > > http://codereview.appspot.com/115085/diff/1/3
> > > File tryton/gui/main.py (right):
> > > 
> > > http://codereview.appspot.com/115085/diff/1/3#newcode980
> > > Line 980: try:
> > > Why a try except ?
> > 
> > Because without I get on first login
> > 
> > Traceback (most recent call last):
> >   File "/usr/src/tmp/tryton/tryton/gui/main.py", line 665, in <lambda>
> >     lambda menuitem: self.sig_statusbar_change(menuitem.get_active()))
> >   File "/usr/src/tmp/tryton/tryton/gui/main.py", line 976, in
> > sig_statusbar_change
> >     return self.sig_statusbar_show()
> >   File "/usr/src/tmp/tryton/tryton/gui/main.py", line 983, in
> sig_statusbar_show
> >     self.status_hbox.show()
> > AttributeError: 'Main' object has no attribute 'status_hbox'
> > 
> > and AFAIS it would afford a major rewrite to get this done without
exception.
> 
> I don't understand because status_hbox is set before in the call set_statusbar
> at line 140
> And any way, a try except for that is bad. You should at least test is
> status_hbox is not None

set_menubar triggers sig_statusbar_show. So set_statusbar has to be called
before set_menubar.

[ced1, 2009-09-10 14:49:06]

Ok for me