AODV model for review

[kevjay]

In order to build through cygwin, I had to change all instances of
UniformVariable::GetValue to UniformVariable::GetInteger as well as remove one
reference to MilliSeconds (0.1) in aodv-routing-protocol.cc, because
MilliSeconds takes uint64_t and it was complaining about getting doubles.

[Pavel Boyko]

I have fixed this in our repository (https://forge.wenos.ru/hgprojects/ns3aodv)
and will upload new changeset after upcoming release. Thank you!

On 2009/09/22 02:10:01, kevjay wrote:
> In order to build through cygwin, I had to change all instances of
> UniformVariable::GetValue to UniformVariable::GetInteger as well as remove one
> reference to MilliSeconds (0.1) in aodv-routing-protocol.cc, because
> MilliSeconds takes uint64_t and it was complaining about getting doubles.

[Shantanu]

Sir,
     I am implementing the AODV protocol in my project using NS-3.5.1.But I am
finding it difficult to run in my machine. It is producing some error. I have
done it twice but the result is same in both times. 
     I have downloaded all the patches that you have released and modified the
existing code of the ns-3.5.1 as you have denoted. But still the code is
producing the same error.
     Sir, please guide me and advice me to do solve my problem. The errors are
enclosed in the mail.
Thanking You.

Yours Sincerely
Shantanu Konwar.

The Konsole gives the following error when I run the AODV.
---------------------------------------------------------------------

program 'scratch/aodv' not found; available programs are: ['emu-sock-creator',
'../../ns-allinone-3.5.1/ns-3.5.1/src/devices/emu/emu-sock-creator',
'tap-creator',
'../../ns-allinone-3.5.1/ns-3.5.1/src/devices/tap-bridge/tap-creator',
'wifi-phy-test',
'../../ns-allinone-3.5.1/ns-3.5.1/src/devices/wifi/wifi-phy-test',
'main-attribute-value',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-attribute-value',
'main-callback', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-callback',
'main-simulator', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simulator',
'main-ptr', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ptr',
'main-random-variable',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-variable',
'main-packet-header',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-header',
'main-packet-tag', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-tag',
'main-test', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test',
'main-test-sync', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test-sync',
'main-simple', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simple',
'main-grid-topology',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-grid-topology',
'main-random-topology',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-topology',
'main-random-walk', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-walk',
'main-propagation-loss',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-propagation-loss',
'main-ns2-mob', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ns2-mob',
'run-tests', '../../ns-allinone-3.5.1/ns-3.5.1/utils/run-tests',
'bench-simulator', '../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-simulator',
'bench-packets', '../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-packets',
'print-introspected-doxygen',
'../../ns-allinone-3.5.1/ns-3.5.1/utils/print-introspected-doxygen',
'hello-simulator', '../../ns-allinone-3.5.1/ns-3.5.1/examples/hello-simulator',
'first', '../../ns-allinone-3.5.1/ns-3.5.1/examples/first', 'second',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/second', 'third',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/third', 'object-names',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/object-names', 'mixed-wireless',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-wireless',
'dynamic-global-routing',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/dynamic-global-routing',
'static-routing-slash32',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/static-routing-slash32',
'global-routing-slash32',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/global-routing-slash32',
'simple-global-routing','../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-global-routing',
'virtual-net-device',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/virtual-net-device',
'simple-alternate-routing',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-alternate-routing',
'simple-error-model',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-error-model',
'csma-one-subnet', '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-one-subnet',
'csma-bridge', '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge',
'csma-bridge-one-hop',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge-one-hop', 'udp-echo',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/udp-echo', 'realtime-udp-echo',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/realtime-udp-echo', 'csma-broadcast',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-broadcast',
'csma-packet-socket',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-packet-socket',
'csma-multicast', '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-multicast',
'mixed-global-routing',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-global-routing',
'simple-point-to-point-olsr',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-point-to-point-olsr',
'tcp-large-transfer',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-large-transfer', 'tcp-nsc-lfn',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-lfn', 'tcp-nsc-zoo',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-zoo', 'tcp-star-server',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-star-server', 'star',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/star', 'csma-star',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-star', 'wifi-adhoc',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-adhoc',
'wifi-clear-channel-cmu',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-clear-channel-cmu', 'wifi-ap',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-ap', 'wifi-example-sim',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/stats/wifi-example-sim',
'wifi-wired-bridging',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-wired-bridging',
'csma-raw-ip-socket',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-raw-ip-socket', 'csma-ping',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-ping', 'test-ipv6',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/test-ipv6', 'emu-udp-echo',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-udp-echo', 'emu-ping',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-ping', 'tap-wifi-dumbbell',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/tap-wifi-dumbbell',
'simple-wifi-frame-aggregation',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-wifi-frame-aggregation',
'multiple-sources',
'../../ns-allinone-3.5.1/ns-3.5.1/scratch/multiple-sources/multiple-sources',
'simple', '../../ns-allinone-3.5.1/ns-3.5.1/scratch/simple']

----------------------------------------------------------------------

I used the following command by keeping the AODV.cc in scratch....

./waf --run scratch/aodv

----------------------------------------------------------------------




On 2009/09/30 15:57:36, Pavel Boyko wrote:
> I have fixed this in our repository
(https://forge.wenos.ru/hgprojects/ns3aodv)
> and will upload new changeset after upcoming release. Thank you!
> 
> On 2009/09/22 02:10:01, kevjay wrote:
> > In order to build through cygwin, I had to change all instances of
> > UniformVariable::GetValue to UniformVariable::GetInteger as well as remove
one
> > reference to MilliSeconds (0.1) in aodv-routing-protocol.cc, because
> > MilliSeconds takes uint64_t and it was complaining about getting doubles.

[Pavel Boyko]

Hi, Shantanu,

  Waf seems to be case-sensitive here (as your filesystem is), try "./waf --run
scratch/AODV". And if you wish to run our test script -- use "./waf --run aodv".

  Also you can avoid applying patches from here and use latest aodv version from
our repository by "hg clone https://forge.iitp.ru/hgprojects/ns3aodv" 

  Good luck,
  Pavel

On 2009/10/12 09:00:28, Shantanu.220984 wrote:
> Sir,
>      I am implementing the AODV protocol in my project using NS-3.5.1.But I am
> finding it difficult to run in my machine. It is producing some error. I have
> done it twice but the result is same in both times. 
>      I have downloaded all the patches that you have released and modified the
> existing code of the ns-3.5.1 as you have denoted. But still the code is
> producing the same error.
>      Sir, please guide me and advice me to do solve my problem. The errors are
> enclosed in the mail.
> Thanking You.
> 
> Yours Sincerely
> Shantanu Konwar.
> 
> The Konsole gives the following error when I run the AODV.
> ---------------------------------------------------------------------
> 
> program 'scratch/aodv' not found; available programs are: ['emu-sock-creator',
> '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/emu/emu-sock-creator',
> 'tap-creator',
> '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/tap-bridge/tap-creator',
> 'wifi-phy-test',
> '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/wifi/wifi-phy-test',
> 'main-attribute-value',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-attribute-value',
> 'main-callback', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-callback',
> 'main-simulator', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simulator',
> 'main-ptr', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ptr',
> 'main-random-variable',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-variable',
> 'main-packet-header',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-header',
> 'main-packet-tag', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-tag',
> 'main-test', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test',
> 'main-test-sync', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test-sync',
> 'main-simple', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simple',
> 'main-grid-topology',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-grid-topology',
> 'main-random-topology',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-topology',
> 'main-random-walk',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-walk',
> 'main-propagation-loss',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-propagation-loss',
> 'main-ns2-mob', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ns2-mob',
> 'run-tests', '../../ns-allinone-3.5.1/ns-3.5.1/utils/run-tests',
> 'bench-simulator', '../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-simulator',
> 'bench-packets', '../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-packets',
> 'print-introspected-doxygen',
> '../../ns-allinone-3.5.1/ns-3.5.1/utils/print-introspected-doxygen',
> 'hello-simulator',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/hello-simulator',
> 'first', '../../ns-allinone-3.5.1/ns-3.5.1/examples/first', 'second',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/second', 'third',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/third', 'object-names',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/object-names', 'mixed-wireless',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-wireless',
> 'dynamic-global-routing',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/dynamic-global-routing',
> 'static-routing-slash32',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/static-routing-slash32',
> 'global-routing-slash32',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/global-routing-slash32',
>
'simple-global-routing','../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-global-routing',
> 'virtual-net-device',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/virtual-net-device',
> 'simple-alternate-routing',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-alternate-routing',
> 'simple-error-model',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-error-model',
> 'csma-one-subnet',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-one-subnet',
> 'csma-bridge', '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge',
> 'csma-bridge-one-hop',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge-one-hop', 'udp-echo',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/udp-echo', 'realtime-udp-echo',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/realtime-udp-echo',
'csma-broadcast',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-broadcast',
> 'csma-packet-socket',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-packet-socket',
> 'csma-multicast', '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-multicast',
> 'mixed-global-routing',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-global-routing',
> 'simple-point-to-point-olsr',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-point-to-point-olsr',
> 'tcp-large-transfer',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-large-transfer', 'tcp-nsc-lfn',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-lfn', 'tcp-nsc-zoo',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-zoo', 'tcp-star-server',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-star-server', 'star',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/star', 'csma-star',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-star', 'wifi-adhoc',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-adhoc',
> 'wifi-clear-channel-cmu',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-clear-channel-cmu', 'wifi-ap',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-ap', 'wifi-example-sim',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/stats/wifi-example-sim',
> 'wifi-wired-bridging',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-wired-bridging',
> 'csma-raw-ip-socket',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-raw-ip-socket', 'csma-ping',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-ping', 'test-ipv6',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/test-ipv6', 'emu-udp-echo',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-udp-echo', 'emu-ping',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-ping', 'tap-wifi-dumbbell',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/tap-wifi-dumbbell',
> 'simple-wifi-frame-aggregation',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-wifi-frame-aggregation',
> 'multiple-sources',
> '../../ns-allinone-3.5.1/ns-3.5.1/scratch/multiple-sources/multiple-sources',
> 'simple', '../../ns-allinone-3.5.1/ns-3.5.1/scratch/simple']
> 
> ----------------------------------------------------------------------
> 
> I used the following command by keeping the AODV.cc in scratch....
> 
> ./waf --run scratch/aodv
> 
> ----------------------------------------------------------------------
> 
> 
> 
> 
> On 2009/09/30 15:57:36, Pavel Boyko wrote:
> > I have fixed this in our repository
> (https://forge.wenos.ru/hgprojects/ns3aodv)
> > and will upload new changeset after upcoming release. Thank you!
> > 
> > On 2009/09/22 02:10:01, kevjay wrote:
> > > In order to build through cygwin, I had to change all instances of
> > > UniformVariable::GetValue to UniformVariable::GetInteger as well as remove
> one
> > > reference to MilliSeconds (0.1) in aodv-routing-protocol.cc, because
> > > MilliSeconds takes uint64_t and it was complaining about getting doubles.

[Shantanu]

Hello Sir,
    Thanks for replying. Refering to your advice I had again gone through the
code but the problem persists. I had also checked the link but sir it asks for a
user name and password which i don't have.
    Sir I request you to take the pain of sending the new code to my email
account. Your kind act is highly solicited.

With Regards
Shantanu Konwar
-----------------------------------------------------------------
email ID:shantanu.220984@gmail.com
-----------------------------------------------------------------




On 2009/10/12 13:47:31, Pavel Boyko wrote:
> Hi, Shantanu,
> 
>   Waf seems to be case-sensitive here (as your filesystem is), try "./waf
--run
> scratch/AODV". And if you wish to run our test script -- use "./waf --run
aodv".
> 
>   Also you can avoid applying patches from here and use latest aodv version
from
> our repository by "hg clone https://forge.iitp.ru/hgprojects/ns3aodv%22 
> 
>   Good luck,
>   Pavel
> 
> On 2009/10/12 09:00:28, Shantanu.220984 wrote:
> > Sir,
> >      I am implementing the AODV protocol in my project using NS-3.5.1.But I
am
> > finding it difficult to run in my machine. It is producing some error. I
have
> > done it twice but the result is same in both times. 
> >      I have downloaded all the patches that you have released and modified
the
> > existing code of the ns-3.5.1 as you have denoted. But still the code is
> > producing the same error.
> >      Sir, please guide me and advice me to do solve my problem. The errors
are
> > enclosed in the mail.
> > Thanking You.
> > 
> > Yours Sincerely
> > Shantanu Konwar.
> > 
> > The Konsole gives the following error when I run the AODV.
> > ---------------------------------------------------------------------
> > 
> > program 'scratch/aodv' not found; available programs are:
['emu-sock-creator',
> > '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/emu/emu-sock-creator',
> > 'tap-creator',
> > '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/tap-bridge/tap-creator',
> > 'wifi-phy-test',
> > '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/wifi/wifi-phy-test',
> > 'main-attribute-value',
> > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-attribute-value',
> > 'main-callback', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-callback',
> > 'main-simulator', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simulator',
> > 'main-ptr', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ptr',
> > 'main-random-variable',
> > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-variable',
> > 'main-packet-header',
> > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-header',
> > 'main-packet-tag',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-tag',
> > 'main-test', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test',
> > 'main-test-sync', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test-sync',
> > 'main-simple', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simple',
> > 'main-grid-topology',
> > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-grid-topology',
> > 'main-random-topology',
> > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-topology',
> > 'main-random-walk',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-walk',
> > 'main-propagation-loss',
> > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-propagation-loss',
> > 'main-ns2-mob', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ns2-mob',
> > 'run-tests', '../../ns-allinone-3.5.1/ns-3.5.1/utils/run-tests',
> > 'bench-simulator', '../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-simulator',
> > 'bench-packets', '../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-packets',
> > 'print-introspected-doxygen',
> > '../../ns-allinone-3.5.1/ns-3.5.1/utils/print-introspected-doxygen',
> > 'hello-simulator',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/hello-simulator',
> > 'first', '../../ns-allinone-3.5.1/ns-3.5.1/examples/first', 'second',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/second', 'third',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/third', 'object-names',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/object-names', 'mixed-wireless',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-wireless',
> > 'dynamic-global-routing',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/dynamic-global-routing',
> > 'static-routing-slash32',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/static-routing-slash32',
> > 'global-routing-slash32',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/global-routing-slash32',
> >
>
'simple-global-routing','../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-global-routing',
> > 'virtual-net-device',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/virtual-net-device',
> > 'simple-alternate-routing',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-alternate-routing',
> > 'simple-error-model',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-error-model',
> > 'csma-one-subnet',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-one-subnet',
> > 'csma-bridge', '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge',
> > 'csma-bridge-one-hop',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge-one-hop', 'udp-echo',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/udp-echo', 'realtime-udp-echo',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/realtime-udp-echo',
> 'csma-broadcast',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-broadcast',
> > 'csma-packet-socket',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-packet-socket',
> > 'csma-multicast',
'../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-multicast',
> > 'mixed-global-routing',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-global-routing',
> > 'simple-point-to-point-olsr',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-point-to-point-olsr',
> > 'tcp-large-transfer',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-large-transfer',
'tcp-nsc-lfn',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-lfn', 'tcp-nsc-zoo',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-zoo', 'tcp-star-server',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-star-server', 'star',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/star', 'csma-star',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-star', 'wifi-adhoc',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-adhoc',
> > 'wifi-clear-channel-cmu',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-clear-channel-cmu',
'wifi-ap',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-ap', 'wifi-example-sim',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/stats/wifi-example-sim',
> > 'wifi-wired-bridging',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-wired-bridging',
> > 'csma-raw-ip-socket',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-raw-ip-socket', 'csma-ping',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-ping', 'test-ipv6',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/test-ipv6', 'emu-udp-echo',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-udp-echo', 'emu-ping',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-ping', 'tap-wifi-dumbbell',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tap-wifi-dumbbell',
> > 'simple-wifi-frame-aggregation',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-wifi-frame-aggregation',
> > 'multiple-sources',
> >
'../../ns-allinone-3.5.1/ns-3.5.1/scratch/multiple-sources/multiple-sources',
> > 'simple', '../../ns-allinone-3.5.1/ns-3.5.1/scratch/simple']
> > 
> > ----------------------------------------------------------------------
> > 
> > I used the following command by keeping the AODV.cc in scratch....
> > 
> > ./waf --run scratch/aodv
> > 
> > ----------------------------------------------------------------------
> > 
> > 
> > 
> > 
> > On 2009/09/30 15:57:36, Pavel Boyko wrote:
> > > I have fixed this in our repository
> > (https://forge.wenos.ru/hgprojects/ns3aodv)
> > > and will upload new changeset after upcoming release. Thank you!
> > > 
> > > On 2009/09/22 02:10:01, kevjay wrote:
> > > > In order to build through cygwin, I had to change all instances of
> > > > UniformVariable::GetValue to UniformVariable::GetInteger as well as
remove
> > one
> > > > reference to MilliSeconds (0.1) in aodv-routing-protocol.cc, because
> > > > MilliSeconds takes uint64_t and it was complaining about getting
doubles.

[Shantanu]

On 2009/10/13 06:25:46, Shantanu wrote:
> Hello Sir,
>     Thanks for replying. Refering to your advice I had again gone through the
> code but the problem persists. I had also checked the link but sir it asks for
a
> user name and password which i don't have.
>     Sir I request you to take the pain of sending the new code to my email
> account. Your kind act is highly solicited.
> 
> With Regards
> Shantanu Konwar
> -----------------------------------------------------------------
> email ID:shantanu.220984@gmail.com
> -----------------------------------------------------------------
> 
> 
> 
> 
> On 2009/10/12 13:47:31, Pavel Boyko wrote:
> > Hi, Shantanu,
> > 
> >   Waf seems to be case-sensitive here (as your filesystem is), try "./waf
> --run
> > scratch/AODV". And if you wish to run our test script -- use "./waf --run
> aodv".
> > 
> >   Also you can avoid applying patches from here and use latest aodv version
> from
> > our repository by "hg clone https://forge.iitp.ru/hgprojects/ns3aodv%2522 
> > 
> >   Good luck,
> >   Pavel
> > 
> > On 2009/10/12 09:00:28, Shantanu.220984 wrote:
> > > Sir,
> > >      I am implementing the AODV protocol in my project using NS-3.5.1.But
I
> am
> > > finding it difficult to run in my machine. It is producing some error. I
> have
> > > done it twice but the result is same in both times. 
> > >      I have downloaded all the patches that you have released and modified
> the
> > > existing code of the ns-3.5.1 as you have denoted. But still the code is
> > > producing the same error.
> > >      Sir, please guide me and advice me to do solve my problem. The errors
> are
> > > enclosed in the mail.
> > > Thanking You.
> > > 
> > > Yours Sincerely
> > > Shantanu Konwar.
> > > 
> > > The Konsole gives the following error when I run the AODV.
> > > ---------------------------------------------------------------------
> > > 
> > > program 'scratch/aodv' not found; available programs are:
> ['emu-sock-creator',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/emu/emu-sock-creator',
> > > 'tap-creator',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/tap-bridge/tap-creator',
> > > 'wifi-phy-test',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/src/devices/wifi/wifi-phy-test',
> > > 'main-attribute-value',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-attribute-value',
> > > 'main-callback', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-callback',
> > > 'main-simulator',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simulator',
> > > 'main-ptr', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ptr',
> > > 'main-random-variable',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-variable',
> > > 'main-packet-header',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-header',
> > > 'main-packet-tag',
> '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-packet-tag',
> > > 'main-test', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test',
> > > 'main-test-sync',
'../../ns-allinone-3.5.1/ns-3.5.1/samples/main-test-sync',
> > > 'main-simple', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-simple',
> > > 'main-grid-topology',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-grid-topology',
> > > 'main-random-topology',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-topology',
> > > 'main-random-walk',
> > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-random-walk',
> > > 'main-propagation-loss',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-propagation-loss',
> > > 'main-ns2-mob', '../../ns-allinone-3.5.1/ns-3.5.1/samples/main-ns2-mob',
> > > 'run-tests', '../../ns-allinone-3.5.1/ns-3.5.1/utils/run-tests',
> > > 'bench-simulator',
'../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-simulator',
> > > 'bench-packets', '../../ns-allinone-3.5.1/ns-3.5.1/utils/bench-packets',
> > > 'print-introspected-doxygen',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/utils/print-introspected-doxygen',
> > > 'hello-simulator',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/hello-simulator',
> > > 'first', '../../ns-allinone-3.5.1/ns-3.5.1/examples/first', 'second',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/second', 'third',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/third', 'object-names',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/object-names',
'mixed-wireless',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-wireless',
> > > 'dynamic-global-routing',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/dynamic-global-routing',
> > > 'static-routing-slash32',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/static-routing-slash32',
> > > 'global-routing-slash32',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/global-routing-slash32',
> > >
> >
>
'simple-global-routing','../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-global-routing',
> > > 'virtual-net-device',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/virtual-net-device',
> > > 'simple-alternate-routing',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-alternate-routing',
> > > 'simple-error-model',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-error-model',
> > > 'csma-one-subnet',
> > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-one-subnet',
> > > 'csma-bridge', '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge',
> > > 'csma-bridge-one-hop',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-bridge-one-hop',
'udp-echo',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/udp-echo', 'realtime-udp-echo',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/realtime-udp-echo',
> > 'csma-broadcast',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-broadcast',
> > > 'csma-packet-socket',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-packet-socket',
> > > 'csma-multicast',
> '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-multicast',
> > > 'mixed-global-routing',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/mixed-global-routing',
> > > 'simple-point-to-point-olsr',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-point-to-point-olsr',
> > > 'tcp-large-transfer',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-large-transfer',
> 'tcp-nsc-lfn',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-lfn', 'tcp-nsc-zoo',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-nsc-zoo',
'tcp-star-server',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tcp-star-server', 'star',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/star', 'csma-star',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-star', 'wifi-adhoc',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-adhoc',
> > > 'wifi-clear-channel-cmu',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-clear-channel-cmu',
> 'wifi-ap',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-ap', 'wifi-example-sim',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/stats/wifi-example-sim',
> > > 'wifi-wired-bridging',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/wifi-wired-bridging',
> > > 'csma-raw-ip-socket',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-raw-ip-socket',
'csma-ping',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/csma-ping', 'test-ipv6',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/test-ipv6', 'emu-udp-echo',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-udp-echo', 'emu-ping',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/emu-ping', 'tap-wifi-dumbbell',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/tap-wifi-dumbbell',
> > > 'simple-wifi-frame-aggregation',
> > > '../../ns-allinone-3.5.1/ns-3.5.1/examples/simple-wifi-frame-aggregation',
> > > 'multiple-sources',
> > >
> '../../ns-allinone-3.5.1/ns-3.5.1/scratch/multiple-sources/multiple-sources',
> > > 'simple', '../../ns-allinone-3.5.1/ns-3.5.1/scratch/simple']
> > > 
> > > ----------------------------------------------------------------------
> > > 
> > > I used the following command by keeping the AODV.cc in scratch....
> > > 
> > > ./waf --run scratch/aodv
> > > 
> > > ----------------------------------------------------------------------
> > > 
> > > 
> > > 
> > > 
> > > On 2009/09/30 15:57:36, Pavel Boyko wrote:
> > > > I have fixed this in our repository
> > > (https://forge.wenos.ru/hgprojects/ns3aodv)
> > > > and will upload new changeset after upcoming release. Thank you!
> > > > 
> > > > On 2009/09/22 02:10:01, kevjay wrote:
> > > > > In order to build through cygwin, I had to change all instances of
> > > > > UniformVariable::GetValue to UniformVariable::GetInteger as well as
> remove
> > > one
> > > > > reference to MilliSeconds (0.1) in aodv-routing-protocol.cc, because
> > > > > MilliSeconds takes uint64_t and it was complaining about getting
> doubles.




Hello Sir,
    Regarding the AODV code of the respective link I want  to ask you that from
where will the aodv-module.h file will be incorporated in the code under ns3
folder. As no such file exist in the whole ns-3.5.1.

    An early reply from your side is highly solicited. Please sir do help me .

Thanking You in Advance.

Shantanu.

[faker.moatamri]

Please find a review of your code.

http://codereview.appspot.com/115075/diff/1/2
File examples/aodv.cc (right):

http://codereview.appspot.com/115075/diff/1/2#newcode37
Line 37: /**
Is it possible to create a header file for class?

http://codereview.appspot.com/115075/diff/1/2#newcode58
Line 58: ///\name parameters
please use doxygen style comments

http://codereview.appspot.com/115075/diff/1/2#newcode77
Line 77: private:
not needed

http://codereview.appspot.com/115075/diff/1/2#newcode202
Line 202: V4PingHelper ping (interfaces.GetAddress(size - 1));
GetAddress (size - 1)
Coding style for all your files please.

http://codereview.appspot.com/115075/diff/1/5
File src/applications/v4ping/v4ping.h (right):

http://codereview.appspot.com/115075/diff/1/5#newcode30
Line 30: /**
good

http://codereview.appspot.com/115075/diff/1/6
File src/contrib/average.h (right):

http://codereview.appspot.com/115075/diff/1/6#newcode32
Line 32: Average () : size(0), min (std::numeric_limits<T>::max ()), max (0),
avg (0), avg2 (0) {}
please coding style, usually after column return to the line and for brackets
also

http://codereview.appspot.com/115075/diff/1/10
File src/helper/aodv-helper.cc (right):

http://codereview.appspot.com/115075/diff/1/10#newcode29
Line 29: AodvHelper::AodvHelper() : Ipv4RoutingHelper ()
coding style

http://codereview.appspot.com/115075/diff/1/16
File src/internet-stack/ipv4-l3-protocol.cc (right):

http://codereview.appspot.com/115075/diff/1/16#newcode684
Line 684: // Do not reply to ICMP or to multicast/broadcast IP address
please avoid white space changes

http://codereview.appspot.com/115075/diff/1/21
File src/node/socket.cc (right):

http://codereview.appspot.com/115075/diff/1/21#newcode48
Line 48: NS_ASSERT(node != 0);
coding style

http://codereview.appspot.com/115075/diff/1/22
File src/routing/aodv/aodv-neighbor.cc (right):

http://codereview.appspot.com/115075/diff/1/22#newcode40
Line 40: Neighbors::Neighbors (Time delay) : m_ntimer (Timer::CANCEL_ON_DESTROY)
coding style and doxygen will be very welcome

http://codereview.appspot.com/115075/diff/1/22#newcode166
Line 166: #ifdef RUN_SELF_TESTS
please turn that into new ns3 testing framwork test frame using test.py

http://codereview.appspot.com/115075/diff/1/24
File src/routing/aodv/aodv-packet.cc (right):

http://codereview.appspot.com/115075/diff/1/24#newcode41
Line 41: switch (m_type)
useless code no?

http://codereview.appspot.com/115075/diff/1/24#newcode138
Line 138: #ifdef RUN_SELF_TESTS
new testing framework...

http://codereview.appspot.com/115075/diff/1/24#newcode294
Line 294: #ifdef RUN_SELF_TESTS
new framework

http://codereview.appspot.com/115075/diff/1/26
File src/routing/aodv/aodv-routing-protocol.cc (right):

http://codereview.appspot.com/115075/diff/1/26#newcode729
Line 729: }
default?

http://codereview.appspot.com/115075/diff/1/27
File src/routing/aodv/aodv-routing-protocol.h (right):

http://codereview.appspot.com/115075/diff/1/27#newcode226
Line 226: Timer htimer;
please use m_hTimer

http://codereview.appspot.com/115075/diff/1/28
File src/routing/aodv/aodv-rqueue.cc (right):

http://codereview.appspot.com/115075/diff/1/28#newcode43
Line 43: #ifdef RUN_SELF_TESTS
new test framework

http://codereview.appspot.com/115075/diff/1/28#newcode143
Line 143: != m_queue.end (); ++i)
please put brackets even though not necessary, it is always recommended to put
brackets (coding style)

http://codereview.appspot.com/115075/diff/1/29
File src/routing/aodv/aodv-rqueue.h (right):

http://codereview.appspot.com/115075/diff/1/29#newcode28
Line 28: #ifndef __aodv_rqueue_h__
usually it's AODV_RQUEUE_H

http://codereview.appspot.com/115075/diff/1/30
File src/routing/aodv/aodv-rtable.cc (right):

http://codereview.appspot.com/115075/diff/1/30#newcode59
Line 59: RoutingTableEntry::~RoutingTableEntry ()
delete m_ipv4Route???

http://codereview.appspot.com/115075/diff/1/30#newcode258
Line 258: RoutingTable::RoutingTable (Time t) : m_badLinkLifetime (t)
new line after :

http://codereview.appspot.com/115075/diff/1/30#newcode327
Line 327: if (i->second.GetNextHop () == nextHop)
{

http://codereview.appspot.com/115075/diff/1/30#newcode445
Line 445: Ptr<NetDevice> dev;
you are missing dev = 0 statement at the end, this might cause memory leaks.

http://codereview.appspot.com/115075/diff/1/31
File src/routing/aodv/aodv-rtable.h (right):

http://codereview.appspot.com/115075/diff/1/31#newcode28
Line 28: #ifndef __aodv_rtable_h__
same thing fo all of .h files, should be AODV_RTABLE_H

http://codereview.appspot.com/115075/diff/1/31#newcode180
Line 180: Timer m_ackTimer;
why this variable is public, you should have a very good reason to do that!

http://codereview.appspot.com/115075/diff/1/32
File src/routing/aodv/aodv.h (right):

http://codereview.appspot.com/115075/diff/1/32#newcode29
Line 29: #ifndef AODV_H_
usually we don't use the last underscore
AODV_H

http://codereview.appspot.com/115075/diff/1/33
File src/routing/aodv/id-cache.cc (right):

http://codereview.appspot.com/115075/diff/1/33#newcode69
Line 69: #ifdef RUN_SELF_TESTS
new test frame...

http://codereview.appspot.com/115075/diff/1/35
File src/routing/aodv/rfc3561.txt (right):

http://codereview.appspot.com/115075/diff/1/35#newcode1
Line 1: 
why you included this file into the code? using a link to the rfc would be
enough.

[Shantanu]

Take a look.

http://codereview.appspot.com/115075/diff/1/2
File examples/aodv.cc (right):

http://codereview.appspot.com/115075/diff/1/2#newcode37
Line 37: /**
On 2009/10/22 20:39:32, faker.moatamri wrote:
> Is it possible to create a header file for class?

Done.

http://codereview.appspot.com/115075/diff/1/8
File src/devices/wifi/adhoc-wifi-mac.cc (right):

http://codereview.appspot.com/115075/diff/1/8#newcode268
Line 268: 
The function "AdhocWifiMac::SetDcaTxop (Ptr<DcaTxop>dcaTxop)" had been skipped.
Where is it?

http://codereview.appspot.com/115075/diff/1/8#newcode270
Line 270: AdhocWifiMac::FinishConfigureStandard (enum WifiPhyStandard standard)
This is not present in NS3.5.1 as default. From where did you get it.

http://codereview.appspot.com/115075/diff/1/30
File src/routing/aodv/aodv-rtable.cc (right):

http://codereview.appspot.com/115075/diff/1/30#newcode327
Line 327: if (i->second.GetNextHop () == nextHop)
On 2009/10/22 20:39:32, faker.moatamri wrote:
> {

Done.

[Pavel Boyko]

Faker, thank you for review. 

I have done almost all proposed fixes, you can pull result from
https://forge.iitp.ru/hgprojects/ns3aodv/ repo (it is in sync with ns-3-dev).
Updated patch will follow in few hours.

http://codereview.appspot.com/115075/diff/1/2
File examples/aodv.cc (right):

http://codereview.appspot.com/115075/diff/1/2#newcode37
Line 37: /**
On 2009/10/22 20:39:32, faker.moatamri wrote:
> Is it possible to create a header file for class?

Sure, but I see no reason for this.

http://codereview.appspot.com/115075/diff/1/2#newcode58
Line 58: ///\name parameters
On 2009/10/22 20:39:32, faker.moatamri wrote:
> please use doxygen style comments

Done. (this _is_ doxyhen style comments).

http://codereview.appspot.com/115075/diff/1/2#newcode77
Line 77: private:
On 2009/10/22 20:39:32, faker.moatamri wrote:
> not needed

I got accustomed to delimit methods and members by extra private: keyword.

http://codereview.appspot.com/115075/diff/1/2#newcode202
Line 202: V4PingHelper ping (interfaces.GetAddress(size - 1));
On 2009/10/22 20:39:32, faker.moatamri wrote:
> GetAddress (size - 1)
> Coding style for all your files please.

Done.

http://codereview.appspot.com/115075/diff/1/6
File src/contrib/average.h (right):

http://codereview.appspot.com/115075/diff/1/6#newcode32
Line 32: Average () : size(0), min (std::numeric_limits<T>::max ()), max (0),
avg (0), avg2 (0) {}
On 2009/10/22 20:39:32, faker.moatamri wrote:
> please coding style, usually after column return to the line and for brackets
> also

Done.

http://codereview.appspot.com/115075/diff/1/8
File src/devices/wifi/adhoc-wifi-mac.cc (right):

http://codereview.appspot.com/115075/diff/1/8#newcode268
Line 268: 
On 2009/10/26 05:59:58, Shantanu wrote:
> The function "AdhocWifiMac::SetDcaTxop (Ptr<DcaTxop>dcaTxop)" had been
skipped.
> Where is it?
> 

I didn't take it.

http://codereview.appspot.com/115075/diff/1/8#newcode270
Line 270: AdhocWifiMac::FinishConfigureStandard (enum WifiPhyStandard standard)
On 2009/10/26 05:59:58, Shantanu wrote:
> This is not present in NS3.5.1 as default. From where did you get it.

M.b. you need to update your NS-3 version.

http://codereview.appspot.com/115075/diff/1/10
File src/helper/aodv-helper.cc (right):

http://codereview.appspot.com/115075/diff/1/10#newcode29
Line 29: AodvHelper::AodvHelper() : Ipv4RoutingHelper ()
On 2009/10/22 20:39:32, faker.moatamri wrote:
> coding style

Done.

http://codereview.appspot.com/115075/diff/1/16
File src/internet-stack/ipv4-l3-protocol.cc (right):

http://codereview.appspot.com/115075/diff/1/16#newcode684
Line 684: // Do not reply to ICMP or to multicast/broadcast IP address
On 2009/10/22 20:39:32, faker.moatamri wrote:
> please avoid white space changes

Done.

http://codereview.appspot.com/115075/diff/1/21
File src/node/socket.cc (right):

http://codereview.appspot.com/115075/diff/1/21#newcode48
Line 48: NS_ASSERT(node != 0);
On 2009/10/22 20:39:32, faker.moatamri wrote:
> coding style

Done.

http://codereview.appspot.com/115075/diff/1/22
File src/routing/aodv/aodv-neighbor.cc (right):

http://codereview.appspot.com/115075/diff/1/22#newcode40
Line 40: Neighbors::Neighbors (Time delay) : m_ntimer (Timer::CANCEL_ON_DESTROY)
On 2009/10/22 20:39:32, faker.moatamri wrote:
> coding style and doxygen will be very welcome

Style (line break after :, right?) fixed. Please find doxygen in headers.

http://codereview.appspot.com/115075/diff/1/22#newcode166
Line 166: #ifdef RUN_SELF_TESTS
On 2009/10/22 20:39:32, faker.moatamri wrote:
> please turn that into new ns3 testing framwork test frame using test.py

Done.

http://codereview.appspot.com/115075/diff/1/24
File src/routing/aodv/aodv-packet.cc (right):

http://codereview.appspot.com/115075/diff/1/24#newcode41
Line 41: switch (m_type)
On 2009/10/22 20:39:32, faker.moatamri wrote:
> useless code no?

Indeed.

http://codereview.appspot.com/115075/diff/1/24#newcode138
Line 138: #ifdef RUN_SELF_TESTS
On 2009/10/22 20:39:32, faker.moatamri wrote:
> new testing framework...

Done.

http://codereview.appspot.com/115075/diff/1/24#newcode294
Line 294: #ifdef RUN_SELF_TESTS
On 2009/10/22 20:39:32, faker.moatamri wrote:
> new framework

Done.

http://codereview.appspot.com/115075/diff/1/26
File src/routing/aodv/aodv-routing-protocol.cc (right):

http://codereview.appspot.com/115075/diff/1/26#newcode729
Line 729: }
On 2009/10/22 20:39:32, faker.moatamri wrote:
> default?

default is omitted to compile-time check that all enum members are correctly
processed.

http://codereview.appspot.com/115075/diff/1/27
File src/routing/aodv/aodv-routing-protocol.h (right):

http://codereview.appspot.com/115075/diff/1/27#newcode226
Line 226: Timer htimer;
On 2009/10/22 20:39:32, faker.moatamri wrote:
> please use m_hTimer

Done.

http://codereview.appspot.com/115075/diff/1/28
File src/routing/aodv/aodv-rqueue.cc (right):

http://codereview.appspot.com/115075/diff/1/28#newcode43
Line 43: #ifdef RUN_SELF_TESTS
On 2009/10/22 20:39:32, faker.moatamri wrote:
> new test framework

Done.

http://codereview.appspot.com/115075/diff/1/28#newcode143
Line 143: != m_queue.end (); ++i)
On 2009/10/22 20:39:32, faker.moatamri wrote:
> please put brackets even though not necessary, it is always recommended to put
> brackets (coding style)

Done.

http://codereview.appspot.com/115075/diff/1/29
File src/routing/aodv/aodv-rqueue.h (right):

http://codereview.appspot.com/115075/diff/1/29#newcode28
Line 28: #ifndef __aodv_rqueue_h__
On 2009/10/22 20:39:32, faker.moatamri wrote:
> usually it's AODV_RQUEUE_H

doesn't matter.

http://codereview.appspot.com/115075/diff/1/30
File src/routing/aodv/aodv-rtable.cc (right):

http://codereview.appspot.com/115075/diff/1/30#newcode59
Line 59: RoutingTableEntry::~RoutingTableEntry ()
On 2009/10/22 20:39:32, faker.moatamri wrote:
> delete m_ipv4Route???

leave this to Ptr::~Ptr

http://codereview.appspot.com/115075/diff/1/30#newcode258
Line 258: RoutingTable::RoutingTable (Time t) : m_badLinkLifetime (t)
On 2009/10/22 20:39:32, faker.moatamri wrote:
> new line after :

Done.

http://codereview.appspot.com/115075/diff/1/30#newcode327
Line 327: if (i->second.GetNextHop () == nextHop)
On 2009/10/22 20:39:32, faker.moatamri wrote:
> {

Done.

http://codereview.appspot.com/115075/diff/1/30#newcode445
Line 445: Ptr<NetDevice> dev;
On 2009/10/22 20:39:32, faker.moatamri wrote:
> you are missing dev = 0 statement at the end, this might cause memory leaks.

This is a myth.

http://codereview.appspot.com/115075/diff/1/31
File src/routing/aodv/aodv-rtable.h (right):

http://codereview.appspot.com/115075/diff/1/31#newcode28
Line 28: #ifndef __aodv_rtable_h__
On 2009/10/22 20:39:32, faker.moatamri wrote:
> same thing fo all of .h files, should be AODV_RTABLE_H

doesn't matter.

http://codereview.appspot.com/115075/diff/1/31#newcode180
Line 180: Timer m_ackTimer;
On 2009/10/22 20:39:32, faker.moatamri wrote:
> why this variable is public, you should have a very good reason to do that!

Yes, it is public.

http://codereview.appspot.com/115075/diff/1/32
File src/routing/aodv/aodv.h (right):

http://codereview.appspot.com/115075/diff/1/32#newcode29
Line 29: #ifndef AODV_H_
On 2009/10/22 20:39:32, faker.moatamri wrote:
> usually we don't use the last underscore
> AODV_H

doesn't matter

http://codereview.appspot.com/115075/diff/1/33
File src/routing/aodv/id-cache.cc (right):

http://codereview.appspot.com/115075/diff/1/33#newcode69
Line 69: #ifdef RUN_SELF_TESTS
On 2009/10/22 20:39:32, faker.moatamri wrote:
> new test frame...

Done.

http://codereview.appspot.com/115075/diff/1/35
File src/routing/aodv/rfc3561.txt (right):

http://codereview.appspot.com/115075/diff/1/35#newcode1
Line 1: 
On 2009/10/22 20:39:32, faker.moatamri wrote:
> why you included this file into the code? using a link to the rfc would be
> enough.

It is very convenient. Though I will not object to remove RFC from public NS
repo (still having it in my own copy).

[upola.aec]

http://codereview.appspot.com/115075/diff/1/12
File src/helper/wscript (left):

http://codereview.appspot.com/115075/diff/1/12#oldcode31
Line 31: 'athstats-helper.cc',
athstats-helper.cc, ipv6-address-helper.cc, ipv6-interface-container.cc are not
found in ns-3.5.1. Are any of the codes in aodv using these files??

http://codereview.appspot.com/115075/diff/1/12#oldcode68
Line 68: 'athstats-helper.h',
the .h files as well are not there. in which NS version did u run the aodv
code??

[Tom Henderson]

This looks good and complete.  My main comments/questions are included below,
but are:
1) can you document what is modelized and what is not?
2) will Socket::Send() return -1 even though route may be discovered later?   
Is the way to limit this to loop back into the same node so that RouteInput()
picks up the packet (can the implementation support such configuration)?

Can the example program also be turned into a system test perhaps?  I would not
object to merging without it but it might be nice to have some kind of example
of operation in the test suite, for code coverage.

http://codereview.appspot.com/115075/diff/10002/9007
File src/contrib/average.h (right):

http://codereview.appspot.com/115075/diff/10002/9007#newcode21
Line 21: #ifndef STATS_H_
ifndef AVERAGE_H_ ? (match class name)

I think it is good to include this in src/contrib for now but we ought to have a
plan for a stats directory or putting it into utils in the future.

http://codereview.appspot.com/115075/diff/10002/9007#newcode59
Line 59: T        Min   () const { return min; }
return size ? min : 0; ?

http://codereview.appspot.com/115075/diff/10002/9019
File src/internet-stack/ipv4-l3-protocol.cc (left):

http://codereview.appspot.com/115075/diff/10002/9019#oldcode479
Line 479: ttl = 1;
will this cause broadcasts to be forwarded, in general (when AODV is not used)?

http://codereview.appspot.com/115075/diff/10002/9025
File src/routing/manet/aodv/aodv-neighbor.cc (right):

http://codereview.appspot.com/115075/diff/10002/9025#newcode52
Line 52: i != m_nb.end (); ++i)
braces on these for loops

http://codereview.appspot.com/115075/diff/10002/9026
File src/routing/manet/aodv/aodv-neighbor.h (right):

http://codereview.appspot.com/115075/diff/10002/9026#newcode95
Line 95: Callback<void, Ipv4Address> m_handleLinleFailure;
m_handleLinkFailure ?

http://codereview.appspot.com/115075/diff/10002/9028
File src/routing/manet/aodv/aodv-packet.h (right):

http://codereview.appspot.com/115075/diff/10002/9028#newcode97
Line 97: |                  Originator Sequence Number                   |
I like this inline verbatim header documentation

http://codereview.appspot.com/115075/diff/10002/9029
File src/routing/manet/aodv/aodv-routing-protocol.cc (right):

http://codereview.appspot.com/115075/diff/10002/9029#newcode274
Line 274: return route;
How does this work for outbound datagrams?  It seems that if AODV has to RREQ, a
null route pointer will be returned by this error, and the socket will return -1
to the Send () call, indicating an error.

http://codereview.appspot.com/115075/diff/10002/9029#newcode442
Line 442: NS_LOG_LOGIC ("AODV does not work with more then one address per each
interface.");
should this assert here?  or at least raise an LOG_ERROR or LOG_WARN?

http://codereview.appspot.com/115075/diff/10002/9029#newcode470
Line 470: return;
perhaps should document somewhere that layer-2 notifications are enabled when
running this model over the AdhocWifiMac interface only.  I don't know whether
it is worth it to try to decouple this class dependency.

http://codereview.appspot.com/115075/diff/10002/9029#newcode558
Line 558: m_routingTable.DeleteAllRoutesFromInterface (address);
what if address is one of the addresses you are ignoring because you only deal
with the first address?

http://codereview.appspot.com/115075/diff/10002/9031
File src/routing/manet/aodv/aodv-rqueue.cc (right):

http://codereview.appspot.com/115075/diff/10002/9031#newcode53
Line 53: != m_queue.end (); ++i)
in general, in many places in this patchset, please put braces on these for
loops.  Braces on the single statement if blocks are generally used in ns-3 but
not required by the coding style, but the loop constructs have braces.

http://codereview.appspot.com/115075/diff/10002/9033
File src/routing/manet/aodv/aodv-rtable.cc (right):

http://codereview.appspot.com/115075/diff/10002/9033#newcode311
Line 311: RoutingTable::MarkLinkAsUinidirectional (Ipv4Address neighbor, Time
blacklistTimeout)
s/Uinidirectional/Unidirectional

http://codereview.appspot.com/115075/diff/10002/9036
File src/routing/manet/aodv/aodv.h (right):

http://codereview.appspot.com/115075/diff/10002/9036#newcode37
Line 37: */
Here it may be nice to list the pieces of RFC3561 that are not supported (if
any), any caveats to the model, etc. and put a URL to the RFC.

(rather than include the RFC verbatim as in the next file)

http://codereview.appspot.com/115075/diff/10002/9037
File src/routing/manet/aodv/rfc3561.txt (right):

http://codereview.appspot.com/115075/diff/10002/9037#newcode16
Line 16: Ad hoc On-Demand Distance Vector (AODV) Routing
I don't see any point in pasting the RFC in here.  What would be more helpful is
a file aodv/aodv.h that describes in doxygen format what is the overall design
of the model and what parts of this RFC are implemented or not, and adds just a
URL to the RFC.

[Elena Buchatskaia]

http://codereview.appspot.com/115075/diff/10002/9007
File src/contrib/average.h (right):

http://codereview.appspot.com/115075/diff/10002/9007#newcode21
Line 21: #ifndef STATS_H_
On 2009/10/28 06:06:07, Tom H. wrote:
> ifndef AVERAGE_H_ ? (match class name)
> 
> I think it is good to include this in src/contrib for now but we ought to have
a
> plan for a stats directory or putting it into utils in the future.

Done.

http://codereview.appspot.com/115075/diff/10002/9025
File src/routing/manet/aodv/aodv-neighbor.cc (right):

http://codereview.appspot.com/115075/diff/10002/9025#newcode52
Line 52: i != m_nb.end (); ++i)
On 2009/10/28 06:06:07, Tom H. wrote:
> braces on these for loops

Done.

http://codereview.appspot.com/115075/diff/10002/9026
File src/routing/manet/aodv/aodv-neighbor.h (right):

http://codereview.appspot.com/115075/diff/10002/9026#newcode95
Line 95: Callback<void, Ipv4Address> m_handleLinleFailure;
On 2009/10/28 06:06:07, Tom H. wrote:
> m_handleLinkFailure ?

Done.

http://codereview.appspot.com/115075/diff/10002/9029
File src/routing/manet/aodv/aodv-routing-protocol.cc (right):

http://codereview.appspot.com/115075/diff/10002/9029#newcode442
Line 442: NS_LOG_LOGIC ("AODV does not work with more then one address per each
interface.");
On 2009/10/28 06:06:07, Tom H. wrote:
> should this assert here?  or at least raise an LOG_ERROR or LOG_WARN?

Done.

http://codereview.appspot.com/115075/diff/10002/9029#newcode558
Line 558: m_routingTable.DeleteAllRoutesFromInterface (address);
On 2009/10/28 06:06:07, Tom H. wrote:
> what if address is one of the addresses you are ignoring because you only deal
> with the first address?

Function FindSocketWithInterfaceAddress return null pointer and thus we go to
line 590.

http://codereview.appspot.com/115075/diff/10002/9031
File src/routing/manet/aodv/aodv-rqueue.cc (right):

http://codereview.appspot.com/115075/diff/10002/9031#newcode53
Line 53: != m_queue.end (); ++i)
On 2009/10/28 06:06:07, Tom H. wrote:
> in general, in many places in this patchset, please put braces on these for
> loops.  Braces on the single statement if blocks are generally used in ns-3
but
> not required by the coding style, but the loop constructs have braces.

Done.

http://codereview.appspot.com/115075/diff/10002/9033
File src/routing/manet/aodv/aodv-rtable.cc (right):

http://codereview.appspot.com/115075/diff/10002/9033#newcode311
Line 311: RoutingTable::MarkLinkAsUinidirectional (Ipv4Address neighbor, Time
blacklistTimeout)
On 2009/10/28 06:06:07, Tom H. wrote:
> s/Uinidirectional/Unidirectional

Done.

http://codereview.appspot.com/115075/diff/10002/9036
File src/routing/manet/aodv/aodv.h (right):

http://codereview.appspot.com/115075/diff/10002/9036#newcode37
Line 37: */
On 2009/10/28 06:06:07, Tom H. wrote:
> Here it may be nice to list the pieces of RFC3561 that are not supported (if
> any), any caveats to the model, etc. and put a URL to the RFC.
> 
> (rather than include the RFC verbatim as in the next file)

Done.

http://codereview.appspot.com/115075/diff/10002/9037
File src/routing/manet/aodv/rfc3561.txt (right):

http://codereview.appspot.com/115075/diff/10002/9037#newcode16
Line 16: Ad hoc On-Demand Distance Vector (AODV) Routing
On 2009/10/28 06:06:07, Tom H. wrote:
> I don't see any point in pasting the RFC in here.  What would be more helpful
is
> a file aodv/aodv.h that describes in doxygen format what is the overall design
> of the model and what parts of this RFC are implemented or not, and adds just
a
> URL to the RFC.

Done.

[Pavel Boyko]

Tom,

  Thank you for thorough review! 

> 1) can you document what is modelized and what is not?

  This is done by Elena in aodv.h, take a look. 

> 2) will Socket::Send() return -1 even though route may be  discovered later? 

  Yes, it will, please see discussion below. 
  
> Is the way to limit this to loop back into the same node > so that
RouteInput() picks up the packet (can the 
> implementation support such  configuration)?

  I don't see how this would help with socket error. Now we store waiting
packets inside AODV and send them using direct access to Ipv4L3Protocol::Send(),
see aodv::RoutingProtocol::SendPacketFromQueue and Send() methods.

>Can the example program also be turned into a system test perhaps?  

  Done, take a look at aodv/test directory (I didn't upload reference traces
here, use our repository to pull them).
We plan to add some more regression tests in near future.

http://codereview.appspot.com/115075/diff/10002/9007
File src/contrib/average.h (right):

http://codereview.appspot.com/115075/diff/10002/9007#newcode59
Line 59: T        Min   () const { return min; }
On 2009/10/28 06:06:07, Tom H. wrote:
> return size ? min : 0; ?

Don't like this. When size == 0 Min() is undefined and max(Type) is much more
clear undefined value that 0.

http://codereview.appspot.com/115075/diff/10002/9019
File src/internet-stack/ipv4-l3-protocol.cc (left):

http://codereview.appspot.com/115075/diff/10002/9019#oldcode479
Line 479: ttl = 1;
On 2009/10/28 06:06:07, Tom H. wrote:
> will this cause broadcasts to be forwarded, in general (when AODV is not
used)?

That depends on routing protocol -- there is no default ("in general") routing
behavior, even for b-casts. Currently implemented protocols don't forward (and
it seems that don't deliver as well) b-casts, grep for "header.GetDestination
().IsBroadcast ()" in src/routing to see this.

One more argument against "ttl = 1" is that I see TTL = 64 for b-cast ping
packets on my Linux box.

http://codereview.appspot.com/115075/diff/10002/9029
File src/routing/manet/aodv/aodv-routing-protocol.cc (right):

http://codereview.appspot.com/115075/diff/10002/9029#newcode274
Line 274: return route;
On 2009/10/28 06:06:07, Tom H. wrote:
> How does this work for outbound datagrams?  It seems that if AODV has to RREQ,
a
> null route pointer will be returned by this error, and the socket will return
-1
> to the Send () call, indicating an error.

That's true. The only thing I can do for socket user is to set errno to
Socket::ERROR_NOTERROR. M.b. we should teach socket implementations do not
return -1 when errno is not an error, I don't know.

For now I just propose to ignore socket errors when using on demand routing.

http://codereview.appspot.com/115075/diff/10002/9029#newcode470
Line 470: return;
On 2009/10/28 06:06:07, Tom H. wrote:
> perhaps should document somewhere that layer-2 notifications are enabled when
> running this model over the AdhocWifiMac interface only.  I don't know whether
> it is worth it to try to decouple this class dependency.

Done. 

Actually we depend on TxErrHeader trace source only, AdhocWifiMac check was
unneded redundant and is removed.  Comment about layer 2 added to aodv.h

[Tom Henderson]

There are a few things combined in this patchset:

1) TTL fix for IPv4L3Protocol
2) v4Ping enhancements
3) AODV model
4) introduction of subdirectory "routing/manet"

I'll go ahead and check in the fix for 1) separately.  As for item 2, I suggest
that you push another Rietveld issue (or put your patch into a new Bugzilla
tracker item) that calls out that these are v4Ping changes.  

I am OK with 4) but I think that OLSR will need to go there too; one question I
have is whether DPD should go there or in src/node with packetbb.  Also, I have
heard that some people are pretty far along with an SMF ns-3 model so I would
like to check with them whether the DPD model is OK with them.

[Pavel Boyko]

Tom, 

  This review is going to be endless. That's why nothing is merged at the early
stages of the release cycle. 

On 2009/11/11 14:52:35, Tom H. wrote:
> There are a few things combined in this patchset:
> 
> 1) TTL fix for IPv4L3Protocol
> 2) v4Ping enhancements
> 3) AODV model
> 4) introduction of subdirectory "routing/manet"

  You forgot to mention contrib/average.h as a separate feature.
 
> I'll go ahead and check in the fix for 1) separately.  

  good, thank you.

> As for item 2, I suggest
> that you push another Rietveld issue (or put your patch into a new Bugzilla
> tracker item) that calls out that these are v4Ping changes. 
 
> I am OK with 4) but I think that OLSR will need to go there too; 

  Sure, this should be the first thing after aodv merge (the second one is to
move packetbb from node to routing/manet/packetbb). Just merge it.

> one question I
> have is whether DPD should go there or in src/node with packetbb.  

  Instead I propose to move packetbb to routing/manet. Since virtually
everything depends on "node" module it should stay as small as possible.

> Also, I have
> heard that some people are pretty far along with an SMF ns-3 model so I would
> like to check with them whether the DPD model is OK with them.

  I was first with the review, so _they_ should check smf with me :) Joke.
Actually SMF defines a number of duplicate packet detection heuristics, we just
use the simplest one (based on packet uid) for aodv. I propose to leave this
question up to SMF review. DPD module is extremely small and can be easily
rewritten/extended to match SMF RFC if needed. Also it can be completely removed
(hidden back to aodv) if it will be not used by other protocols during some time
(say 0.5 year). 

  So far you say nothing about AODV (point 3 of your list above). Do you think
it is ready to be merged? 

  Pavel

[Tom Henderson]

>   So far you say nothing about AODV (point 3 of your list above). Do you think
> it is ready to be merged? 
> 

Sorry, somehow I did not see this reply two days ago.  Yes, I agree to merge
AODV now.  I will post to ns-developers to notify that you are proposing also to
merge the other changes that are not AODV-specific.

[Mariusz Skrocki]

Hi,
I'm not entirely sure, but it seems to me that in the method RoutingTable::Purge
() is missing 'else' clause for external 'if' statement... 
In this case, if the timeout of the table entry has expired, we increment
iterator 'i' twice...?

[Pavel Boyko]

Good catch! Fixed. 

On 2009/11/18 08:00:10, mskrocki wrote:
> Hi,
> I'm not entirely sure, but it seems to me that in the method
RoutingTable::Purge
> () is missing 'else' clause for external 'if' statement... 
> In this case, if the timeout of the table entry has expired, we increment
> iterator 'i' twice...?

[Mariusz Skrocki]

I have a small problem... 
I wanted to compare the functionality and efficiency of the AODV protocol in
ns-3 with the implementation in JIST/SWANS. One of the tested topology was a
matrix of nodes, to which in each simulation I added one row and one column of
nodes. The flow of data was set between the first and last node in the network,
located at two ends of the diagonal of the network. I noticed that an increasing
number of nodes in the network couses bigger packet loss, which is obvious,
however, these losses were growing much faster than in simulation using JIST. 
I reviewed the logs from the simulation along with a colleague and we noticed
that sometimes in the routing table in nodes there appears a strange entry, in
which the source, destination and gateway address are set to 102.102.102.102.
The entry is added to the routing table at the time when the source node sends a
RREQ, because there is no entry corresponding to the target node. 
As we noted after receiving the RREP message corresponding to RREQ, the source
node adds a new entry to its routing table, but does not remove the entry
containing the address of 102.102.102.102. Would not be better if we add an
empty entry specifying, however,  the RREQ Destination address?

void
RoutingProtocol::SendRequest (Ipv4Address dst)
...
  RoutingTableEntry rt;
  if (m_routingTable.LookupRoute (dst, rt))
    {
      rreqHeader.SetHopCount (rt.GetHop ());
      if (rt.GetValidSeqNo ())
        rreqHeader.SetDstSeqno (rt.GetSeqNo ());
      else
        rreqHeader.SetUnknownSeqno (true);
      rt.SetFlag (IN_SEARCH);
      m_routingTable.AddRoute (rt);
    }
  else
    {
      rreqHeader.SetUnknownSeqno (true);
      RoutingTableEntry newEntry;
      newEntry.SetFlag (IN_SEARCH);
      newEntry.SetDestination(dst);   // Shouldn't we add destination address to
the entry?
      m_routingTable.AddRoute (newEntry);
    }
…
}


We found also that the problem exists also in RouteRequestTimerExpire method,
because it does not check whether the entry was found in the routing table.
Shouldn't we check here whether the entry was found in the routing table?

void
RoutingProtocol::RouteRequestTimerExpire (Ipv4Address dst)
{
  NS_LOG_LOGIC(this);
  RoutingTableEntry toDst;

  if (!m_routingTable.LookupRoute (dst, toDst)) // Shouldn't we check it here?
    { 
      return;
    }

  if (toDst.GetFlag () == VALID)
    {
      SendPacketFromQueue (dst, toDst.GetRoute ());
      NS_LOG_LOGIC ("route to " << dst << " found from " <<
toDst.GetInterface().GetLocal());
      return;
    }
…

--
Yours Sincerely
Mariusz Skrocki