Issue 115073: [PATCH] Make TypeBuilder's result depend on the LLVMContext it's passed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115073: [PATCH] Make TypeBuilder's result depend on the LLVMContext it's passed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by Jeffrey Yasskin

Modified:
14 years, 7 months ago

Reviewers:
resistor

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Description

Make TypeBuilder's result depend on the LLVMContext it's passed. TypeBuilder was using a local static variable to cache its result. This made it ignore changes in its LLVMContext argument and always return a type constructed from the argument to the first call.

Patch Set 1 #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -97 lines)			Patch
	M	include/llvm/Support/TypeBuilder.h	View		17 chunks	+12 lines, -97 lines	0 comments	Download
	M	unittests/Support/TypeBuilderTest.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

The patch is at http://codereview.appspot.com/download/issue115073_1.diff. I'm going to ask Tanya to merge this into 2.6 ...

14 years, 8 months ago (2009-09-09 00:52:33 UTC) #1

Looks fine to me.  Approved.

Expand All Messages | Collapse All Messages