Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10993)

Issue 114840043: Doc: Appendix - Articulations and Ornamentation - part 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by pkx166h
Modified:
9 years, 9 months ago
Reviewers:
dak, Mark Polesky
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Appendix - Articulations and Ornamentation - part 2 Issue 1189 Create Texifo @multitable entries for the List of Articulations appendix. As there are a lot of separate scripts being documented this Issue is going to be split into multiple, smaller, parts to aid in the review process. Part 1 was commit 8553021 This is part 2 and covers 'Fermata', 'Instrument specific', 'Repeat signs' and 'Ancient' scripts. Also, after more consideration, a third example of each script has been added to show the explicit differences between the up/down/neutral positions. Not every script has a different up/down glyph nor is positioned up/down when placed on a note that is either top or bottom of the Staff without explicit positioning. So this, I hope just clarifies things (regardless whether the position is musically 'correct' notation). I have also sey the @code{} script examples into the same column as the @lilypond examples; saving a significant of wasted page space. Also I have removed unnecessary lilypond-book variables making the texinfo code less noisy.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changed from 5 to 4 column @multitable entries to see if this allows make doc #

Patch Set 3 : Added third example in each case so as to use up/down/neutral positions. Corrected some previous in… #

Patch Set 4 : ugh.. missed the @multitable settings between copying/pasting on my scratch lilypond-book file to t… #

Patch Set 5 : Added remaining tables upto but not including Percussion. That will be handled in a separate patch. #

Total comments: 16

Patch Set 6 : Mark P's suggestion about adding shorttcuts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -158 lines) Patch
M Documentation/notation/notation-appendices.itely View 1 2 3 4 5 2 chunks +255 lines, -158 lines 0 comments Download

Messages

Total messages: 11
pkx166h
Changed from 5 to 4 column @multitable entries to see if this allows make doc
9 years, 9 months ago (2014-07-16 12:58:30 UTC) #1
dak
https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1547 Documentation/notation/notation-appendices.itely:1547: @multitable @columnfractions .20 .20 .20 .20 .20 No @headitem? ...
9 years, 9 months ago (2014-07-16 13:09:55 UTC) #2
pkx166h
Added third example in each case so as to use up/down/neutral positions. Corrected some previous ...
9 years, 9 months ago (2014-07-20 12:18:48 UTC) #3
pkx166h
Thanks David for the review, I have also edited the commit message. https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely ...
9 years, 9 months ago (2014-07-20 12:23:09 UTC) #4
pkx166h
ugh.. missed the @multitable settings between copying/pasting on my scratch lilypond-book file to test the ...
9 years, 9 months ago (2014-07-20 12:26:45 UTC) #5
pkx166h
Added remaining tables upto but not including Percussion. That will be handled in a separate ...
9 years, 9 months ago (2014-07-20 12:33:13 UTC) #6
pkx166h
You can download a 2 page PDF showing just the lilypond-book output from here: https://www.hightail.com/download/ZUcyak96Y1NCSWNkVU1UQw
9 years, 9 months ago (2014-07-20 14:26:08 UTC) #7
Mark Polesky
https://codereview.appspot.com/114840043/diff/80001/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): https://codereview.appspot.com/114840043/diff/80001/Documentation/notation/notation-appendices.itely#newcode1513 Documentation/notation/notation-appendices.itely:1513: attached to notes (eg. @samp{f\accent}). Each example shows the ...
9 years, 9 months ago (2014-07-24 20:22:39 UTC) #8
pkx166h
Mark P's suggestion about adding shorttcuts
9 years, 9 months ago (2014-07-25 17:33:05 UTC) #9
pkx166h
Thanks Mark. Note I went with @code{} or @code{} and have had to include a ...
9 years, 9 months ago (2014-07-25 17:34:56 UTC) #10
pkx166h
9 years, 9 months ago (2014-07-31 21:26:36 UTC) #11
author	James Lowe <pkx166h@gmail.com>	
	Tue, 15 Jul 2014 21:21:10 +0000 (22:21 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Thu, 31 Jul 2014 21:24:43 +0000 (22:24 +0100)
commit	4d6f2a27cc17261bc0970327de8665a6b771734b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b