Issue 11455046: Corrections to LM (Issue 3407)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11455046: Corrections to LM (Issue 3407) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by PhilEHolmes

Modified:
10 years, 8 months ago

Reviewers:
Graham Percival, Trevor Daniels, Jean-Charles

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

A minor change to try to make the dynamics spacing section at least accurate - ditto a small change on fingering placement.

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -32 lines)			Patch
	M	Documentation/learning/tweaks.itely	View		4 chunks	+14 lines, -32 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Trevor Daniels

Apart from a minor nitpick LGTM https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely#newcode2801 Documentation/learning/tweaks.itely:2801: of a string ...

10 years, 9 months ago (2013-07-23 11:30:52 UTC) #2

Jean-Charles

Except one nitpick, LGTM https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely#newcode2387 Documentation/learning/tweaks.itely:2387: by the trick of setting ...

10 years, 9 months ago (2013-07-23 16:53:39 UTC) #3

LGTM

Expand All Messages | Collapse All Messages