Issue 1144041: Make sure that floats are written with at least one decimal point.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1144041: Make sure that floats are written with at least one decimal point. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Alok Priyadarshi

Modified:
14 years ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Make sure that floats are written with at least one decimal point.

Patch Set 3 : '' #

Total comments: 1

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	src/compiler/InfoSink.h	View	1 2	2 chunks	+15 lines, -4 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kbr1

http://codereview.appspot.com/1144041/diff/1/2 File src/compiler/InfoSink.h (right): http://codereview.appspot.com/1144041/diff/1/2#newcode17 src/compiler/InfoSink.h:17: modf(f, &integral); modf returns the fractional part so the ...

14 years ago (2010-05-06 18:44:03 UTC) #3

Alok Priyadarshi

14 years ago (2010-05-06 19:08:10 UTC) #4

kbr1

14 years ago (2010-05-06 20:55:16 UTC) #5

LGTM

http://codereview.appspot.com/1144041/diff/7001/8001
File src/compiler/InfoSink.h (right):

http://codereview.appspot.com/1144041/diff/7001/8001#newcode16
src/compiler/InfoSink.h:16: return fmodf(f, 1.0f);
Oops, sorry, I was wrong. This is OK, or you can use return modff(f, &tmp);.
modff may be more efficient.

Expand All Messages | Collapse All Messages