Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 1142041: Fixed all issues with variable and function argument declaration. Multiple de... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by Alok Priyadarshi
Modified:
15 years, 3 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed all issues with variable and function argument declaration. Multiple declarations of arrays in the same line had bugs. Also sepearated out declaration of varaibles and function arguments which makes it easier to understand.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -78 lines) Patch
M src/compiler/OutputGLSL.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/OutputGLSL.cpp View 1 6 chunks +109 lines, -77 lines 0 comments Download

Messages

Total messages: 4
Alok Priyadarshi
15 years, 3 months ago (2010-05-06 18:03:42 UTC) #1
kbr1
LGTM. One comment. http://codereview.appspot.com/1142041/diff/1/3 File src/compiler/OutputGLSL.cpp (right): http://codereview.appspot.com/1142041/diff/1/3#newcode105 src/compiler/OutputGLSL.cpp:105: void TOutputGLSL::writeVariableDeclaration(const TType& type) Consider naming ...
15 years, 3 months ago (2010-05-06 18:35:46 UTC) #2
Alok Priyadarshi
http://codereview.appspot.com/1142041/diff/1/3 File src/compiler/OutputGLSL.cpp (right): http://codereview.appspot.com/1142041/diff/1/3#newcode105 src/compiler/OutputGLSL.cpp:105: void TOutputGLSL::writeVariableDeclaration(const TType& type) On 2010/05/06 18:35:46, kbr1 wrote: ...
15 years, 3 months ago (2010-05-06 19:05:38 UTC) #3
kbr1
15 years, 3 months ago (2010-05-06 20:49:57 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b