Doc: NR: Using \partial with \repeat.

Doc: NR: Using \partial with \repeat.

[Graham Percival (old account), 2010-05-11 01:19:28]

LGTM

http://codereview.appspot.com/1136044/diff/1/2
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/1136044/diff/1/2#newcode172
Documentation/notation/repeats.itely:172: ...such that @code{a}/@code{b}
indicates the length of the partial
@noindent is discouraged, but if you must use it, don't begin with "...".

http://codereview.appspot.com/1136044/diff/1/2#newcode176
Documentation/notation/repeats.itely:176: command with
@samp{\unset@tie{}Score.measureLength}, otherwise the
Ick.  I'd rather just see @samp{\unset Score.measurLength}, since that's what we
do everywhere else in the docs.  If you're really concerned about having
linebreaks inside tweak commands, then work on the general way to avoid
linebreaks inside @samp.  That way, all the manuals benefit, and the doc source
is still easy to read.

[Carl, 2010-05-11 02:37:54]

Hi Mark,

I think it can get even more straightforward.  I've made some suggestions below.

Thanks,

Carl

http://codereview.appspot.com/1136044/diff/1/2
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/1136044/diff/1/2#newcode126
Documentation/notation/repeats.itely:126: Repeats that begin after the initial
partial measure of a score:
This should be a sentence, rather than just a phrase.

http://codereview.appspot.com/1136044/diff/1/2#newcode139
Documentation/notation/repeats.itely:139: For simple repeats that @emph{include}
the initial partial measure
Does this apply only for a repeat that includes an initial upbeat? or does it
apply (as I think it does) to *any* repeat that starts with a partial measure?

It seems to me we should be talking about repeats that start with a partial
measure and have no alternative endings in this case.

I think we can get simpler and more straightforward.

http://codereview.appspot.com/1136044/diff/1/2#newcode159
Documentation/notation/repeats.itely:159: If alternate endings are added to a
repeat that includes the
It seems to me that from here to line 181 could be shortened to something like:

When a repeat begins with a partial measure, and more than one alternative
ending is present, all the alternative except the last need to be modified.  The
final measure of each of these alternatives should be shortened so that the
final measure together with the initial partial measure form a complete measure:

(There should be a cross reference to the place in the Notation Reference that
describes the use of measureLength, rather than explaining it here, IMO)

[Neil Puttock, 2010-05-11 20:43:19]

http://codereview.appspot.com/1136044/diff/1/2
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/1136044/diff/1/2#newcode159
Documentation/notation/repeats.itely:159: If alternate endings are added to a
repeat that includes the
On 2010/05/11 02:37:54, Carl wrote:

> (There should be a cross reference to the place in the Notation Reference that
> describes the use of measureLength, rather than explaining it here, IMO)

+1, though wherever it's discussed, `Timing' should be used instead of `Score',
in case a user's doing polymetric stuff (since the timing info will be set in
the Staff context).

[Carl, 2010-05-17 10:12:14]

LGTM.

I think the first example is no longer needed.

Thanks,

Carl

http://codereview.appspot.com/1136044/diff/6001/7001
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/1136044/diff/6001/7001#newcode126
Documentation/notation/repeats.itely:126: Repeats that begin after the initial
partial measure of a score:
Why have this example here?  The repeat doesn't have an upbeat (or pickup, or
anacrusis, or \partial ;-) ) so I think this whole example can go away with the
rewriting you've done.

[Graham Percival (old account), 2010-05-17 17:40:16]

Looks fine to me.

[Mark Polesky, 2010-05-17 20:07:33]

On 2010/05/17 17:40:16, Graham Percival wrote:
> Looks fine to me.

Do you agree with Carl that I should remove this?
http://codereview.appspot.com/1136044/diff/6001/7001#newcode126

- Mark

[Neil Puttock, 2010-05-17 21:53:57]

LGTM.

I'm with Carl on removing the first example.

Cheers,
Neil

http://codereview.appspot.com/1136044/diff/6001/7002
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/1136044/diff/6001/7002#newcode2935
Documentation/notation/rhythms.itely:2935: \set Timing.measurePosition =
#(ly:make-moment 5 8)
remove indent

[Graham Percival, 2010-05-17 23:00:22]

On Mon, May 17, 2010 at 08:07:33PM +0000, markpolesky@gmail.com wrote:
> Message:
> On 2010/05/17 17:40:16, Graham Percival wrote:
>> Looks fine to me.
>
> Do you agree with Carl that I should remove this?
> http://codereview.appspot.com/1136044/diff/6001/7001#newcode126

Yes, it should be removed... but OTOH if you'd pushed the patch
as-is, I wouldn't have complained about that.  But since you're
asking: yes, please remove that example, and then push.  :)

Cheers,
- Graham