Issue 1125043: Replaces fmod with modf.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1125043: Replaces fmod with modf. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 1 month ago by Alok Priyadarshi

Modified:
16 years, 1 month ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : '' #

Created: 16 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/compiler/InfoSink.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

LGTM http://codereview.appspot.com/1125043/diff/1/2 File src/compiler/InfoSink.h (right): http://codereview.appspot.com/1125043/diff/1/2#newcode17 src/compiler/InfoSink.h:17: return modf(f, &intPart); I think this is picking ...

16 years, 1 month ago (2010-05-06 22:35:45 UTC) #2

Alok Priyadarshi

16 years, 1 month ago (2010-05-06 22:49:21 UTC) #3

http://codereview.appspot.com/1125043/diff/1/2
File src/compiler/InfoSink.h (right):

http://codereview.appspot.com/1125043/diff/1/2#newcode17
src/compiler/InfoSink.h:17: return modf(f, &intPart);
On 2010/05/06 22:35:46, kbr1 wrote:
> I think this is picking up the overloaded C++ version of modf. It might be
> better to use modff explicitly. I'm not sure which one is more portable. modff
> is present in the Mac and Windows math.h headers but I'm not sure about Linux.
> 

Done.

Expand All Messages | Collapse All Messages