Issue 112280043: CG: Update of Patchy instructions (Closed)
|
Created:
9 years, 9 months ago by pkx166h Modified:
9 years, 9 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionCG: Update of Patchy instructions
Added fuller explanatory information regarding Patchy.
Includes examples of running the scripts and sections
on troubleshooting when things go wrong.
Patch Set 1 #Patch Set 2 : Spelling mistakes corrected. #
Total comments: 14
Patch Set 3 : Alts from Julien R and some minor rewrites myself #
Total comments: 14
Patch Set 4 : Mark P and Julien R comments - minor edits and typos #MessagesTotal messages: 9
Spelling mistakes corrected.
Sign in to reply to this message.
Thanks for this! Some comments. Cheers, Julien https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:161: knowledge of of compiling LilyPond and its documentation along with "of of" https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:172: requires some human intervention in order to to visually check for any "to to" https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:178: compile, including building all the LilyPond documentation, finally The script makes sure that the new HEAD compiles, it does not attempt to compile every individual commit. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:238: Commit access @emph{is} required to test patches, but a valid login "to test patches" -> "to test and push new commits" https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:256: of the @file{patches/} directory to your @var{PATH}. Would be useful to give the exact command line to clone the repo. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:430: The script can also be run using a @emph{single} tracker issue number as You can have multiple arguments, each an issue number. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:525: @unnumberedsubsubsec Checking the regression test results OK, I made it this far.
Sign in to reply to this message.
Alts from Julien R and some minor rewrites myself
Sign in to reply to this message.
Thanks Julien https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:161: knowledge of of compiling LilyPond and its documentation along with On 2014/07/21 18:30:32, Julien Rioux wrote: > "of of" Done. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:172: requires some human intervention in order to to visually check for any On 2014/07/21 18:30:32, Julien Rioux wrote: > "to to" Done. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:178: compile, including building all the LilyPond documentation, finally On 2014/07/21 18:30:32, Julien Rioux wrote: > The script makes sure that the new HEAD compiles, it does not attempt to compile > every individual commit. Done. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:238: Commit access @emph{is} required to test patches, but a valid login On 2014/07/21 18:30:32, Julien Rioux wrote: > "to test patches" -> "to test and push new commits" Done. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:256: of the @file{patches/} directory to your @var{PATH}. On 2014/07/21 18:30:32, Julien Rioux wrote: > Would be useful to give the exact command line to clone the repo. Done. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:430: The script can also be run using a @emph{single} tracker issue number as On 2014/07/21 18:30:31, Julien Rioux wrote: > You can have multiple arguments, each an issue number. Done. https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor... Documentation/contributor/administration.itexi:525: @unnumberedsubsubsec Checking the regression test results On 2014/07/21 18:30:32, Julien Rioux wrote: > OK, I made it this far. :) Thanks. I have made some other alts after some re-reading myself
Sign in to reply to this message.
Don't think it needs another countdown cycle, so the changes below could be made before pushing. Cheers, Julien https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:591: The tracker issue's lable is then changed automatically to label https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:606: lable is changed automatically to @qq{Patch-Needs_work}. label https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:627: 02 0-23/2 * * * /home/joe/lilypond-extra/patches/lilypond-patchy-staging.py joe -> patchy https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:694: This occurs when Patchy detects that the commit ID is has not changed "is has" -> "has"
Sign in to reply to this message.
https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:354: branches (prefrixed with @code{test-}) with a third branch, called prefixed https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:712: A previous test attempt was unsuccesful for some reason and the scripts unsuccessful https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:783: merge from staging replace tabs with spaces
Sign in to reply to this message.
Thanks for checking. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:354: branches (prefrixed with @code{test-}) with a third branch, called On 2014/07/24 21:11:24, Mark Polesky wrote: > prefixed Done. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:591: The tracker issue's lable is then changed automatically to On 2014/07/24 19:32:50, Julien Rioux wrote: > label Done. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:606: lable is changed automatically to @qq{Patch-Needs_work}. On 2014/07/24 19:32:50, Julien Rioux wrote: > label Done. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:627: 02 0-23/2 * * * /home/joe/lilypond-extra/patches/lilypond-patchy-staging.py On 2014/07/24 19:32:50, Julien Rioux wrote: > joe -> patchy Done. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:694: This occurs when Patchy detects that the commit ID is has not changed On 2014/07/24 19:32:50, Julien Rioux wrote: > "is has" -> "has" Done. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:712: A previous test attempt was unsuccesful for some reason and the scripts On 2014/07/24 21:11:24, Mark Polesky wrote: > unsuccessful Done. https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor... Documentation/contributor/administration.itexi:783: merge from staging On 2014/07/24 21:11:24, Mark Polesky wrote: > replace tabs with spaces Done.
Sign in to reply to this message.
Mark P and Julien R comments - minor edits and typos
Sign in to reply to this message.
author James Lowe <pkx166h@gmail.com> Sat, 12 Jul 2014 21:41:57 +0000 (22:41 +0100) committer James Lowe <pkx166h@gmail.com> Sun, 27 Jul 2014 04:16:51 +0000 (05:16 +0100) commit 70fccf7aad2e0f5e62e5dca5fb5f9e2cecc35865
Sign in to reply to this message.
|
